Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

fix: advise setting 'CRC32C_PURE_PYTHON' after build failure - #84

Merged
tseaver merged 4 commits into
mainfrom
83-emit-warning-for-build-failure
Sep 1, 2021
Merged

tseaver merged 4 commits into
mainfrom
83-emit-warning-for-build-failure

Conversation

@tseaver

@tseaver tseaver commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

Toward #83.

@tseaver
tseaver requested review from a team and andrewsg August 31, 2021 22:37
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 minor observations, otherwise LGTM.

Comment thread setup.py Outdated
Comment thread setup.py Outdated

@andrewsg andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tseaver
tseaver merged commit 6aa1cd6 into main Sep 1, 2021
@tseaver
tseaver deleted the 83-emit-warning-for-build-failure branch September 1, 2021 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants