Replies: 1 comment
|
Ideally I would look at your commit changes and decide from there whether it's something I would want to import. Note that months ago I decided to drop using |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Context
npm testin the repo is currently a stub (echo "Error: no test specified" && exit 1). The JSONPath RFC 9535 conformance corpus exists but lives in a browser-only harness (tools/jsonpath-tests.html) that renders results into the DOM, so it can't run in CI. The static network filtering parser has no standalone unit tests despite being logic-dense and actively changed (e.g. the recent "consecutive$$" fix).Proposal
Add small, dependency-free headless test runners under
tools/, using the built-innode:testrunner. They importsrc/jsmodules directly, so no build step is required:AstFilterParser(network / cosmetic / scriptlet / html / responseheader / error), including a regression group for the consecutive-$$interpretation.npm testtonode --test "./tools/*.node.js".Result on my branch: 64 assertions pass, 17 unsupported-RFC-9535 cases tracked as pending, 0 failures;
npm run lintclean.Question
Would a PR along these lines be welcome? I have it implemented and can open it against
master, or adjust the scope/approach to your preference.All reactions