gh-86997: Fix IDLE widget colors in macOS dark mode - #157679
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Widgets with only one hard-coded color got the other one from the system, which made text unreadable in dark mode. The debugger stack list and the stack viewer now use the colors of the IDLE theme, and the squeezed text button and the debugger error label set both colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, Tk takes the default widget colors from the system, so a widget with only one hard-coded color gets the other one for the opposite appearance, and the text becomes unreadable in dark mode. Four such places were found:
ScrolledList) had onlybackground="white"; it now uses the colors of the IDLE theme, like the tree-based viewers (this also makes it fit the IDLE Dark theme);bg="white"while its labels use the theme colors; it now uses the theme background, as the module browser does;Supersedes #121772 (thanks to @tadeja for the analysis of the debugger case).
🤖 Generated with Claude Code