Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flush_unmatched()callsStop()on a context before freeing it, andStop()runs the external timer while that context is still the current one. A timer that callsenable()re-armssys.monitoringmid-call, so the unmatched C return that follows reachesptrace_leave_call()and pushes the context onto the free list.flush_unmatched()then frees it, and the nextptrace_enter_call()reads the dangling pointer.POF_EXT_TIMERalready exists to keep the external timer from reaching the profiler's state, so honour it in the two trace callbacks and drop events raised while the timer runs.Fixes #157639