Skip to content

Update main for TS7 tagged releases - #64286

Open
Jake Bailey (jakebailey) wants to merge 12 commits into
microsoft:mainfrom
jakebailey:prototype-release-workflows
Open

Jake Bailey (jakebailey) wants to merge 12 commits into
microsoft:mainfrom
jakebailey:prototype-release-workflows

Conversation

@jakebailey

Copy link
Copy Markdown
Member

In prep for 7.0.3.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release configuration script’s SemVer validation accepts invalid versions and rejects valid build metadata.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Restores and modernizes release-branch automation for upcoming releases.

Changes:

  • Adds shared release-version configuration and branch synchronization.
  • Updates branch creation/version workflows with validation.
  • Improves cherry-pick baseline conflict handling.
File summaries
File Description
tools/scripts/configure-release.mjs Synchronizes release version declarations.
Herebyfile.mjs Disables nightly VSIX builds on release branches.
.github/workflows/sync-branch.yaml Adds release-branch synchronization.
.github/workflows/set-version.yaml Modernizes version updates.
.github/workflows/new-release-branch.yaml Modernizes release-branch creation.
.github/workflows/create-cherry-pick-pr.yml Improves cherry-pick validation and baselines.
.github/disabled-workflows/sync-branch.yaml Removes the obsolete disabled workflow.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/scripts/configure-release.mjs Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two workflows copy the release script without its required SemVer module, causing configuration to fail.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

.github/workflows/set-version.yaml:80

  • configure-release.mjs imports ./semver.mjs, but this step copies only the entry point into $RUNNER_TEMP. Node resolves that import relative to the copied module, so the configure step fails with ERR_MODULE_NOT_FOUND before updating the branch. Copy the dependency alongside the script (or make the fetched script self-contained).
  • Files reviewed: 9/9 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/sync-branch.yaml
@jakebailey Jake Bailey (jakebailey) changed the title Restore release management workflows Update main for TS7 tagged releases Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unsupported prereleases can be published as latest, and the package-test task fails standalone on clean checkouts.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread tools/scripts/configure-release.mjs Outdated
Comment thread Herebyfile.mjs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

It changes privileged signing, publishing, tagging, and branch-push workflows that require live CI validation.

Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Sep 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Accepted prerelease versions can collide on the same GitHub tag after npm publication.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread tools/pipelines/typescript-publish.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Needs merge

Development

Successfully merging this pull request may close these issues.

3 participants