Skip to content

macOS Rework: Toolbar - #32365

Draft
iccir wants to merge 22 commits into
matplotlib:mainfrom
iccir:macos-pr-toolbar
Draft

macOS Rework: Toolbar#32365
iccir wants to merge 22 commits into
matplotlib:mainfrom
iccir:macos-pr-toolbar

Conversation

@iccir

@iccir iccir commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR summary

Important

This PR depends on #32161 and will appear larger than it really is until #32161 is merged. To view the actual changes in this PR, compare macos-staging → macos-pr-toolbar.

This PR adjusts the appearance of the navigation toolbar and its buttons.

In addition, it:

  • Fixes layout so the window corner doesn't overlap the Home button.
  • Uses a single menu button when there isn't enough room to display all buttons.
  • Adds main menu entries for the various toolbar actions.
  • Adds support for macOS's "Increase contrast" accessibility setting. This adds a one pixel outline to the buttons and toolbar.
  • Adds support for macOS's "Keyboard navigation" option. This allows the user to press Tab and Shift-Tab to cycle through controls. When turned on, the backend will route Tab to the system and not create key_press_event/key_release_event events.
Screenshot showing the four different variants. Screenshot showing the compact width menu button.

AI Disclosure

  • I use AI for web search due to search engines becoming less reliable.
  • All code is my own.

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • [N/A] New and changed code is tested (Tested manually)
  • [N/A] Plotting related features are demonstrated in an example
  • [N/A] New features and API changes have release notes
  • [N/A] Documentation complies with general and docstring guidelines

iccir added 22 commits July 30, 2026 20:02
@iccir
Rename files to "legacymac"
1826f72
@iccir
First pass at moving files from macosx-staging
b0b62e4
@iccir
Global symbol renames in _legacymac.m
beb44ad 
Obj-C classes:
MatplotlibAppDelegate -> MPLLegacyAppDelegate
Window -> MPLLegacyWindow
View -> MPLLegacyView
NavigationToolbar2Handler -> MPLLegacyNavigationToolbar2Handler
@iccir
Make process_event static
728186f
@iccir
Migrate to reworked implementation
49cd061
@iccir
Use existing app icon for now
2d5d3e3
@iccir
Merge branch 'main' of https://github.com/matplotlib/matplotlib into …
aefd730 
…macos-staging
@iccir
Fix too many lines
23ce2c8
@iccir
Add "legacymac" and "macos"
32a4e67
@iccir
Add "macos" to RcGroupKeyType
5c2a304
@iccir
Fixing long line
946a4e6
@iccir
Add "LegacyMac" and "macOS" to docstring
ef2fa09
@iccir
Fix shim for test case failure
8968f2a
@iccir
Address AI feedback and pull some changes from rework branch
6199da9
@iccir
Fixing pre-commit failures
33bef74
@iccir
Limit Python.h usage
7bd0e0c
@iccir
Adding placeholder files
40048c6
@iccir
Updating section name
c47c02b
@iccir
Merge remote-tracking branch 'origin/main' into macos-staging
d9a32b9
@iccir
Add type parameter to new rcparams
4c2b912
@iccir
Add MPLGetRGBColor and MPLGetCenteredRect
49a385e
@iccir
Rework toolbar appearance and accessibility features
d5e83bf
@iccir iccir mentioned this pull request Sep 17, 2026
Open
@iccir iccir added this to the v3.12.0 milestone Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

GUI: MacOSX status: waiting for other PR

Projects

None yet

Milestone

v3.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@iccir @QuLogic