The Wayback Machine - https://web.archive.org/web/20210209013142/https://github.com/GoogleChrome/web.dev/pull/2549
Skip to content

/ web.dev

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unignore lots of files and fix their eslint errors. #2549

Merged
merged 2 commits into from Apr 10, 2020
Merged

Unignore lots of files and fix their eslint errors. #2549

merged 2 commits into from Apr 10, 2020

Conversation

@robdodson
Copy link
Collaborator

@robdodson robdodson commented Apr 10, 2020 •
edited

Changes proposed in this pull request:

  • Unignores lib/* and any of our dotfiles.
  • Fixes linter issues with the aforementioned files. Mostly tweaks spaces and swaps single for double quotes.
  • Switch to single quotes! 🍾
@robdodson
Unignore lots of files and fix their eslint errors.
Loading status checks…
76e0753
@robdodson robdodson requested a review from MichaelSolati Apr 10, 2020
@robdodson robdodson requested a review from samthor as a code owner Apr 10, 2020
@googlebot googlebot added the cla: yes label Apr 10, 2020
@netlify
Copy link

@netlify netlify bot commented Apr 10, 2020 •
edited

Deploy preview for web-dev-staging ready!

Built with commit a2e7ed0

https://deploy-preview-2549--web-dev-staging.netlify.com
@MichaelSolati
MichaelSolati approved these changes Apr 10, 2020
View changes
Copy link
Contributor

@MichaelSolati MichaelSolati left a comment

Is now a good of time as any to shift to single quotes?
@robdodson
Single quote all the things!
Loading status checks…
a2e7ed0
@robdodson robdodson merged commit b3a7292 into master Apr 10, 2020
6 checks passed
6 checks passed
lhci
Details
lint_and_test
Details
percy
Details
cla/google All necessary CLAs are signed
netlify/web-dev-staging/deploy-preview Deploy preview ready!
Details
percy/site Visual review approved by Rob Dodson
Details
@robdodson robdodson deleted the task/unignore-eslint-files branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSolati MichaelSolati

@samthor samthor

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@robdodson @MichaelSolati @googlebot