gh-89544: Fix IDLE hang after Restart Shell while receiving output - #157644
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
RPCClient.accept() reinitializes the SocketIO for the new connection, but the receive buffer kept the partially received packet from the old connection, so no message from the new user process was ever complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restart_subprocess()reuses theMyRPCClientobject:close(), thenaccept()callsSocketIO.__init__()again for the new connection. It resets the socket, responses and condition variables, but not the receive buffer, which was kept in class attributes shadowed by instance attributes. After Restart Shell while the GUI was receiving a large output (for example the result of'a'*1_600_000), the partially received packet was kept, the QUEUED reply totransfer_path()from the new user process was appended to it, and the GUI process waited forever for a complete packet with the Tk event loop blocked.Now the receive buffer is initialized per connection.
🤖 Generated with Claude Code