Skip to content

Update PyPy CI Specifier - #467

Merged
pradyunsg merged 2 commits into
pypa:mainfrom
mattip:pypy-ci
Oct 14, 2021
Merged

pradyunsg merged 2 commits into
pypa:mainfrom
mattip:pypy-ci

Conversation

@mattip

@mattip mattip commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

pypy3 is being deprecated as a specifier, see actions/setup-python#244. Right now this affects macos-latest, but I imagine it will percolate through the other os images as well. The current CI here has not failed, I think because the image is cached.

@mattip

mattip commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

I am not well-versed in nox. The github setup-python specifier is now pypy-3.7, the executable in the created environment can be one of pypy3, pypy3.7, pypy, python, python3, or python3.7. Is nox looking for pypy-3.7? That is not one of the options.

@pradyunsg

Copy link
Copy Markdown
Member

Comment thread .github/workflows/test.yml Outdated
@mattip

mattip commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

Adding another if clause did the trick

Comment thread docs/development/getting-started.rst Outdated
In the end the old invocation was correct

Co-authored-by: Pradyun Gedam <[email protected]>
@pradyunsg pradyunsg closed this Oct 14, 2021
@pradyunsg pradyunsg reopened this Oct 14, 2021
@pradyunsg

Copy link
Copy Markdown
Member

You didn't modify any .py files, so the required runs aren't running anymore. 🤣

It's fine though -- I can tick the admin checkbox and merge this.

@pradyunsg pradyunsg changed the title update pypy ci specifier Update PyPy CI Specifier Oct 14, 2021
@pradyunsg
pradyunsg merged commit 42e1396 into pypa:main Oct 14, 2021
@mattip mattip mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants