gh-67804: Do not let Undo delete output in the IDLE Shell - #157697
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Output is now inserted below the undo delegator, so it is not recorded for undo, and the undo stack is reset when output is written. Holding Undo while a statement runs no longer deletes its output and the statement itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output written to the Shell was recorded by the undo delegator, so holding Undo while a statement was running deleted its output and then the statement itself. Now output is inserted below the undo delegator, so it is not recorded, and the undo stack is reset when output is written, because its entries refer to positions after the output. Undo can only affect what was typed since the last output.
🤖 Generated with Claude Code