Conversation
Signed-off-by: Dayun <[email protected]>
dayun6530
marked this pull request as ready for review
September 17, 2026 01:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66075 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.02%
==========================================
Files 787 789 +2
Lines 270307 271560 +1253
Branches 51726 51829 +103
==========================================
+ Hits 243890 245078 +1188
- Misses 16899 16928 +29
- Partials 9518 9554 +36
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the worker exit cleanup so
messageerrorlisteners are removed before theexitevent is emitted.Adds a regression test covering the listener cleanup behavior.
Tests:
python3 tools/test.py --mode=release parallel/test-worker-messageerror-listener-cleanupmake lint-jsFixes: #65782