Skip to content

Rust: rust-analyzer update automation - #22590

Open
paldepind wants to merge 9 commits into
mainfrom
paldepind/rust-analyzer-update-automation
Open

paldepind wants to merge 9 commits into
mainfrom
paldepind/rust-analyzer-update-automation

Conversation

@paldepind

@paldepind paldepind commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

This PR adds automation for updating rust-analyzer in the Rust extractor.

We:

  • Move the human-readable rust-analyzer update instructions to a separate file, such that an agent can read them without reading the entire readme.
  • Add a Python script that deterministically runs the fixed steps related to updating the extractor.
  • Add some additions to the readme instructions. The step numbers in the readme are aligned with the script.
  • Add an agentic workflow. The workflow runs the script and then starts the agent from there. The intention is that we don't waste token having the agent carry out instructions that are simple enough that a script can handle them.

Guide to reviewer:

  • The Python script is what I consider the most valuable part of this PR – so I think focusing on that makes sense.
  • The changes to the instructions are best seen by the diff in 04e44e9.
  • The agentic workflow is entirely AI generated. I've skimmed it and confirmed that it looks reasonable, and I'd expect a reviewer to do no more. I have no way of running it locally. My understanding is that since it's a new workflow we'll have to merge it before we can run it. I think we should just merge it, and then I'll fix stuff in follow up PRs if it turns out to not work.

@github-actions github-actions Bot added documentation Rust Pull requests that update Rust code labels Sep 16, 2026
@paldepind
paldepind marked this pull request as ready for review September 16, 2026 13:16
@paldepind
paldepind requested review from a team as code owners September 16, 2026 13:16
Copilot AI balanced review requested due to automatic review settings September 16, 2026 13:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The workflow has safe-output configuration gaps, and several documentation links and commands are incorrect.

Get a fresh assessment by requesting another Copilot review.

Review tier: Balanced
Findings: 2 Medium severity · 5 Low severity

Open (7)
What changed in this PR

Adds automated rust-analyzer updates for the Rust extractor.

Changes:

  • Adds a deterministic updater script and instructions.
  • Adds an agentic workflow and generated lock file.
  • Marks compiled workflows as generated.
File Description
rust/​updating-rust-analyzer.md Documents the update process.
rust/​scripts/​update_rust_analyzer.py Automates dependency, toolchain, codegen, and build steps.
rust/​README.md Links to the extracted instructions.
.github/​workflows/​update-rust-analyzer.md Defines the agentic workflow.
.github/​workflows/​update-rust-analyzer.lock.yml Contains the compiled workflow.
.gitattributes Marks workflow lock files as generated.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/update-rust-analyzer.md
Comment thread .github/workflows/update-rust-analyzer.md
Comment thread rust/README.md Outdated
Comment thread rust/scripts/update_rust_analyzer.py Outdated
Comment thread rust/updating-rust-analyzer.md Outdated
Comment thread rust/updating-rust-analyzer.md Outdated
Comment thread rust/updating-rust-analyzer.md Outdated
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Comment thread .github/workflows/update-rust-analyzer.md Outdated
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Comment thread .github/workflows/update-rust-analyzer.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants