Unified: Add exception CFG edges from try expressions. - #22589
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Exception edges are placed after an entire compound try operand rather than at its potentially throwing call sites.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds Swift exception CFG edges for try expressions and enables catch-clause flow.
Changes:
- Introduces language-specific CFG plugins.
- Models
tryas a possible exception source. - Updates Swift CFG tests and generated expectations.
| File | Description |
|---|---|
ControlFlowGraph.qll |
Integrates exception completions. |
ControlFlowGraphPlugin.qll |
Defines the plugin interface. |
ControlFlowGraphPluginSwift.qll |
Implements Swift try handling. |
cfg.swift |
Adds CFG assertions. |
cfg.expected |
Updates generated CFG results. |
basicblock-slices.expected |
Updates generated block slices. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aschackmull
marked this pull request as draft
September 16, 2026 11:38
aschackmull
force-pushed
the
unified/cfg-try-exception
branch
from
September 16, 2026 12:02
a11af2e to
ea20259
Compare
aschackmull
marked this pull request as ready for review
September 16, 2026 12:02
asgerf
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a swift CFG plugin and adds support for exception edges originating from
try-prefixed calls.