Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Fix/add saucelabs eu dc - #5083

Merged
cnishina merged 7 commits into
angular:masterfrom
wswebcreation:fix/add-saucelabs-eu-dc
Dec 19, 2018
Merged

cnishina merged 7 commits into
angular:masterfrom
wswebcreation:fix/add-saucelabs-eu-dc

Conversation

@wswebcreation

Copy link
Copy Markdown
Contributor

Proposed changes

SauceLabs is expanding their services to other regions in the world. Protractor wants to allow user to easily pick between DCs.

Types of changes

This change allows user to define the backend region from sauce via the sauceRegion property, e.g.

    sauceUser: process.env.SAUCE_USERNAME,
    sauceKey: process.env.SAUCE_ACCESS_KEY,
    sauceRegion: 'eu',

Will run the test against https://ondemand.eu-central-1.saucelabs.com:443/wd/hub/.

    sauceUser: process.env.SAUCE_USERNAME,
    sauceKey: process.env.SAUCE_ACCESS_KEY,
    sauceRegion: 'us',

    // the default
    sauceUser: process.env.SAUCE_USERNAME,
    sauceKey: process.env.SAUCE_ACCESS_KEY,

Will run the test against https://ondemand.saucelabs.com:443/wd/hub/

It will also set the correct url for updating the status of the test

@christian-bromann christian-bromann left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cnishina
cnishina merged commit db1b638 into angular:master Dec 19, 2018
@wswebcreation
wswebcreation deleted the fix/add-saucelabs-eu-dc branch January 4, 2019 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants