Conversation
|
View your CI Pipeline Execution ↗ for commit ae56155
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
CatchABus
marked this pull request as draft
September 16, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
In android 12 and later, root launcher activities are no longer finished on Back press.
However, {N} core overrides backpress and removes frames from stack at times, thinking that the activity will finish.
Then, user attempts to launch the app and it will simply resume without recreating views and frames will still be missing from the stack.
That results in Frame
topmost()andgetFrameById()returning a wrong frame instance in apps with multiple frames.What is the new behavior?
This PR uses a workaround in loaded lifecycle to ensure the removed frames regain their place in the frame stack.Because the stack push function may change the position of an existing frame in it, we make sure to check
_isInFrameStacktoo before acting.The PR also removes an unneeded override of_popFromFrameStack.Fixes/Closes #11436.