Conversation
When parserConfiguration({ 'strip-dashed': true }) is enabled, argv stores
showHidden instead of show-hidden, so filterHiddenOptions never saw the flag.
Check camelCase and kebab-case keys so --show-hidden (and custom names) work.
Fixes yargs#2356
Member
|
This looks like a drive-by AI contribution. This may get looked at and used when the issue is prioritised. The human maintainer does not have time to review all AI heavy PRs that are opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2356.
When
parserConfiguration({ 'strip-dashed': true })is enabled, yargs-parser stores camelCased keys onargv(showHiddeninstead ofshow-hidden).filterHiddenOptionsonly looked upargv[showHiddenOpt], so--show-hidden(and custom show-hidden flag names) never revealed hidden options in help output.This is a minimal fix in
lib/usage.ts: also check the camelCase and kebab-case forms of the configured show-hidden option key. Intentionally smaller than #2516 (closed as too heavy for this edge case).Motivation and Context
--help --show-hiddenshould list hidden options even whenstrip-dashedis on. Without this, apps that prefer camelCase argv silently lose the ability to surface hidden options via the documented flag.How Has This Been Tested?
test/usage.mjsfor:--show-hidden+strip-dashedshowHidden('custom-show-hidden')+strip-dashedstrip-dashedhidden optionssuite and the strip-dashed conflict validation test — all passing.Types of changes
Checklist: