Ignore a URL with an unsupported scheme - #447
Merged
Merged
Conversation
tidoust
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 16, 2018
…ed (#9966) Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added: - To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed - To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified
markafoltz
reviewed
Mar 22, 2018
markafoltz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. One editorial suggestion.
| <li>Resolve <var>U</var> relative to the API base URL specified | ||
| by the <a>current settings object</a>, and add the resulting | ||
| absolute URL (if any) to <var>presentationUrls</var>. | ||
| absolute URL (if any, and if the resulting scheme is supported |
Contributor
There was a problem hiding this comment.
This might be easier to read if it were broken into three steps. Here is one way that could be done.
- Let A be absolute URL that is the result of resolving U relative to the API base URL specified by the current settings object.
- If the parse a URL algorithm failed, then throw a SyntaxError exception and abort all remaining steps.
- If A has a scheme supported by the controlling user agent, add A to presentationUrls.
Contributor
Author
There was a problem hiding this comment.
LGTM. Thanks for your suggestion.
Contributor
Author
|
@mfoltzgoogle PTAL |
markafoltz
approved these changes
Mar 26, 2018
markafoltz
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one minor typo
| <li>Resolve <var>U</var> relative to the API base URL specified | ||
| by the <a>current settings object</a>, and add the resulting | ||
| absolute URL (if any) to <var>presentationUrls</var>. | ||
| <li>let <var>A</var> be an absolute URL that is the result of |
Contributor
|
Merging, can fix the typo in a followup commit. |
markafoltz
added a commit
that referenced
this pull request
Mar 26, 2018
Contributor
Author
|
@mfoltzgoogle Many thanks for your review and fixing the typo. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2018
… unsupported scheme is ignored, a=testonly Automatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966) Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added: - To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed - To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
… unsupported scheme is ignored, a=testonly Automatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966) Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added: - To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed - To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 UltraBlame original commit: 7b6feb16ae6fe5ee0889b819b649b2b41e003893
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
… unsupported scheme is ignored, a=testonly Automatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966) Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added: - To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed - To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 UltraBlame original commit: 7b6feb16ae6fe5ee0889b819b649b2b41e003893
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
… unsupported scheme is ignored, a=testonly Automatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966) Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added: - To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed - To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 UltraBlame original commit: 7b6feb16ae6fe5ee0889b819b649b2b41e003893
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
… unsupported scheme is ignored, a=testonly Automatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966) Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added: - To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed - To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966 wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3 wpt-pr: 9966
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #446.
Preview | Diff