Conversation
Removes outdated section on roleInfo.js and replaces it with current information Resolves #2830
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Deployed on https://deploy-preview-2885--wai-aria.netlify.app |
daniel-montalvo
left a comment
There was a problem hiding this comment.
Thanks for these updates @pkra
Couple of thoughts:
- Would be nice to include the exact command to update roleInfo for easier reference.
- Also, I think it would be fair to qualify more the bit about copying the diff to the PR comments because of the accessibility issues of reading the github action logs.
I didn't want to encourage this as it's complicated (setting up nodejs, getting a compiled spec etc).
Could you make a suggestion? |
spectranaut
left a comment
There was a problem hiding this comment.
This is certainly an improvement/more up-to-date :)
Another reasons not to do this occurred to me - keeping updates in sync is always harder than it may seem. |
|
@daniel-montalvo I've added a warning regarding the github action UI. |
giacomo-petri
left a comment
There was a problem hiding this comment.
just a minor typo; approving already
|
@daniel-montalvo ping? |
Removes outdated section on roleInfo.js
and replaces it with current information
Resolves #2830