Skip to content

Update documentation of trusted-click-element #4068

Description

@plazer1

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

The documentation of trusted-click-element currently states that its "reference API" is https://github.com/AdguardTeam/Scriptlets/blob/master/src/scriptlets/trusted-click-element.ts. However, its API has recently changed and no longer corresponds to that of AdGuard. The documentation should be updated to reflect the recent API changes.

A specific URL where the issue occurs.

https://github.com/gorhill/uBlock/blob/2c23c298d5fa7d998d9d397a610ece42ff405abc/src/js/resources/scriptlets.js#L1655

Steps to Reproduce

See incorrect documentation at https://github.com/gorhill/uBlock/blob/2c23c298d5fa7d998d9d397a610ece42ff405abc/src/js/resources/scriptlets.js#L1655

Expected behavior

The DocString of trusted-click-element should describe the API in great detail.

Troubleshooting information

uBlock Origin: 1.72.2
Firefox: 149
filterset (summary):
 network: 222720
 cosmetic: 284100
 scriptlet: 72417
 html: 3975
listset (total-discarded, last-updated):
 added:
  ublock-experimental: 18-0, 2h.38m Δ
  adguard-generic: 98216-5842, 3d.57m
  adguard-mobile: 12584-75, 3d.57m
  adguard-spyware-url: 2580-134, 3d.57m
  block-lan: 91-0, 3d.57m
  adguard-cookies: 39480-115, 3d.57m
  ublock-cookies-adguard: 5807-81, 1h.50m
  fanboy-cookiemonster: 47083-3892, 3d.57m
  adguard-social: 26626-45, 3d.57m
  fanboy-social: 17720-869, 3d.57m
  fanboy-thirdparty_social: 69-18, 3d.57m
  adguard-popup-overlays: 32104-1074, 3d.57m
  [10 lists not shown]: [too many]
 default:
  user-filters: 34-1, never
  ublock-filters: 52939-72, 2h.38m Δ
  ublock-badware: 10364-27, 2h.38m Δ
  ublock-privacy: 4072-2, 2h.38m Δ
  ublock-unbreak: 2854-1, 2h.38m Δ
  ublock-quick-fixes: 483-13, 2h.38m Δ
  easylist: 90284-1320, 2h.38m Δ
  easyprivacy: 56032-139, 2h.38m Δ
  urlhaus-1: 47370-10, 2h.38m
  plowe-0: 3517-1118, 4d.11h.39m
filterset (user): [array of 36 redacted]
trustedset:
 added: [array of 3 redacted]
 removed:
  moz-extension-scheme
userSettings:
 userFiltersTrusted: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 10469 ms (selfie)
 maxAssetCacheWait: 3101 ms
 cacheBackend: indexedDB

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions