Prerequisites
I tried to reproduce the issue when...
Description
I have just updated the Cliqz benchmarks with the latest versions of Adblock Plus (ghostery/adblocker@a2da894) and Brave (ghostery/adblocker@97dc7c1)
Unfortunately it's not trivial to do the same for uBlock Origin, because of the relative tight coupling in the code. In fact, it keeps getting harder. For example, uritools.js now refers to the vAPI object whereas previously it did not.
It would be ideal if the core filter parsing, matching, and serialization functionality were split out into a separate Node.js module.
A specific URL where the issue occurs
N/A
Steps to Reproduce
Try to update the benchmarks at https://github.com/cliqz-oss/adblocker/tree/master/packages/adblocker-benchmarks with the latest version of uBlock Origin.
Expected behavior
It should be as easy as updating a version number or a commit hash in the package.json file in that repo.
Actual behavior
It's too much work that involves copying and modifying a bunch of files from the uBlock Origin repo.
uBlock Origin version
1.36.2
Browser name and version
N/A
Operating System and version
N/A
Prerequisites
I tried to reproduce the issue when...
Description
I have just updated the Cliqz benchmarks with the latest versions of Adblock Plus (ghostery/adblocker@a2da894) and Brave (ghostery/adblocker@97dc7c1)
Unfortunately it's not trivial to do the same for uBlock Origin, because of the relative tight coupling in the code. In fact, it keeps getting harder. For example,
uritools.jsnow refers to thevAPIobject whereas previously it did not.It would be ideal if the core filter parsing, matching, and serialization functionality were split out into a separate Node.js module.
A specific URL where the issue occurs
N/A
Steps to Reproduce
Try to update the benchmarks at https://github.com/cliqz-oss/adblocker/tree/master/packages/adblocker-benchmarks with the latest version of uBlock Origin.
Expected behavior
It should be as easy as updating a version number or a commit hash in the
package.jsonfile in that repo.Actual behavior
It's too much work that involves copying and modifying a bunch of files from the uBlock Origin repo.
uBlock Origin version
1.36.2
Browser name and version
N/A
Operating System and version
N/A