Skip to content

fix(webapp): stop the sidebar feedback popover from canceling the submit - #4445

Merged
isshaddad merged 5 commits into
mainfrom
fix/tri-12817-sidebar-feedback-popover
Aug 2, 2026
Merged

fix(webapp): stop the sidebar feedback popover from canceling the submit#4445
isshaddad merged 5 commits into
mainfrom
fix/tri-12817-sidebar-feedback-popover

Conversation

@isshaddad

@isshaddad isshaddad commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

The Help & Feedback → "Contact us" form in the sidebar intermittently failed to send. The <Feedback> dialog was nested inside the Help popover, so clicking Send closed the popover and unmounted the form mid-submit — canceling the POST /resources/feedback before it went out. The message was silently lost (the success toast still shows). A race, so it "worked sometimes"; the standalone "I'm stuck!" path was unaffected.

Fix: host the Feedback dialog outside the popover (same pattern as AskAIRoot) and open it from the menu item, so closing the popover no longer tears down the form. Feedback gains an optional controlled open/setOpen mode; existing button-triggered usages are unchanged.

Changes

  • Feedback.tsx — optional controlled open/setOpen; button now optional.
  • HelpAndFeedbackPopover.tsx — "Contact us…" opens a <Feedback> hosted outside PopoverContent.
  • .server-changes/fix-sidebar-feedback.md — user-facing note.

Testing

Webapp typecheck passes. Sidebar "Contact us…" now sends on every attempt (Network: POST /resources/feedback → 204, never (canceled)); "I'm stuck!" and the ?feedbackPanel= open path unchanged.

@changeset-bot

changeset-bot Bot commented Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0fb709a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c2a7355c-a715-4aff-8e8b-2ce60d9e387f

📥 Commits

Reviewing files that changed from the base of the PR and between 7f4a619 and 0fb709a.

📒 Files selected for processing (1)
  • apps/webapp/app/components/Feedback.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/webapp/app/components/Feedback.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout. (17)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: typecheck / typecheck
  • GitHub Check: runops-guard / runops-guard
  • GitHub Check: code-quality / code-quality
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

The Feedback component now accepts controlled open and setOpen props while retaining internal state when they are absent. Its trigger renders only when a button is provided. The help menu closes before opening the feedback dialog, which is rendered outside the popover. A server change note documents the sidebar contact form fix.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary fix for canceled sidebar feedback submissions.
Description check ✅ Passed The description explains the bug, fix, affected files, and testing results; it omits some template sections but remains mostly complete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tri-12817-sidebar-feedback-popover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@isshaddad
isshaddad force-pushed the fix/tri-12817-sidebar-feedback-popover branch from a0f2c95 to 7f4a619 Compare August 2, 2026 13:03
@pkg-pr-new

pkg-pr-new Bot commented Aug 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@27a8602

trigger.dev

npm i https://pkg.pr.new/trigger.dev@27a8602

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@27a8602

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@27a8602

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@27a8602

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@27a8602

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@27a8602

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@27a8602

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@27a8602

commit: 27a8602

@isshaddad
isshaddad marked this pull request as ready for review August 2, 2026 13:15
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@isshaddad
isshaddad enabled auto-merge (squash) August 2, 2026 13:38
@isshaddad
isshaddad merged commit 8f66af6 into main Aug 2, 2026
36 checks passed
@isshaddad
isshaddad deleted the fix/tri-12817-sidebar-feedback-popover branch August 2, 2026 13:49
@github-actions github-actions Bot mentioned this pull request Aug 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@ericallam ericallam ericallam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isshaddad @ericallam