Add native Visual Studio build instructions for Windows - #219
Open
ManasBagul23 wants to merge 2 commits into
Open
ManasBagul23 wants to merge 2 commits into
ManasBagul23 wants to merge 2 commits into
Conversation
Document how to build SU2 with MSVC and Microsoft MPI from the x64 Native Tools Command Prompt, including the need to leave with-mpi at its default (Meson only detects MS-MPI for C) and to disable CGNS (the bundled HDF5 does not compile with MSVC). The MinGW instructions are kept and marked as written for SU2 v7.
There was a problem hiding this comment.
🟡 Changes recommended
Clarify branch prerequisites and replace the obsolete MinGW distribution link.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds native Visual Studio/MS-MPI build instructions for Windows while retaining the SU2 v7 MinGW workflow.
Changes:
- Documents MSVC prerequisites, configuration, compilation, and runtime commands.
- Clarifies MPI and CGNS limitations.
- Updates Windows build guidance and branch-specific context.
File summaries
| File | Summary |
|---|---|
_docs_v7/Build-SU2-Windows.md |
Adds MSVC build documentation and reorganizes Windows instructions. |
Review details
Suppressed comments (2)
_docs_v7/Build-SU2-Windows.md:9
- This overview still links to the obsolete mingw.org distribution, while the new note at line 99 says that distribution cannot compile current SU2. Link this entry to the MinGW-w64 installer used below so the overview does not direct readers to a known-incompatible toolchain.
- the [Minimalist GNU for Windows](http://www.mingw.org/) development environment (MinGW).
_docs_v7/Build-SU2-Windows.md:36
- These instructions are presented as tested against
develop, but the MSVC prerequisite fix in SU2#2900 is still an open, unmerged PR, and without it the currentdevelopbranch fails on thestd::array::begin()raw-pointer build error. Please either document a source revision that contains this fix (or how to apply it) or publish this page only once the upstream fix is available.
These instructions were tested on Windows 11 with Python 3.10, MSVC 19.44 (Visual Studio 2022 Build Tools) and Microsoft MPI 10.1.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - Git, if you clone the source code (download [here](https://git-scm.com/download/win)) | ||
| - Optional, for parallel runs: Microsoft MPI (download [here](https://www.microsoft.com/en-us/download/details.aspx?id=100593), you need the `msmpisetup.exe` and the `msmpisdk.msi`) | ||
|
|
||
| These instructions were tested on Windows 11 with Python 3.10, MSVC 19.44 (Visual Studio 2022 Build Tools) and Microsoft MPI 10.1. |
Author
There was a problem hiding this comment.
Added a note that the MSVC instructions need a version of SU2 that includes su2code/SU2#2900 (now merged into develop), and that v8.5.0 does not compile with MSVC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds instructions to
_docs_v7/Build-SU2-Windows.mdfor building SU2 natively with MSVC and Microsoft MPI. They were tested on Windows 11 with Visual Studio 2022 Build Tools (MSVC 19.44), Python 3.10 and MS-MPI 10.1, building SU2 develop and running a case withmpiexec -n 2.The page notes that
with-mpihas to stay at its default (Meson only detects MS-MPI for C, forcing it also requires the C++ detection which fails) and that CGNS has to be disabled (the bundled HDF5 does not compile with MSVC). The existing MinGW instructions are kept and marked as written for SU2 v7.Related Work
su2code/SU2#1468. Building develop with MSVC requires su2code/SU2#2900.