Skip to content

fix: update wasm binaries for recently updated packages - #13837

Open
0PrashantYadav0 wants to merge 3 commits into
stdlib-js:developfrom
0PrashantYadav0:build-fix
Open

fix: update wasm binaries for recently updated packages#13837
0PrashantYadav0 wants to merge 3 commits into
stdlib-js:developfrom
0PrashantYadav0:build-fix

Conversation

@0PrashantYadav0

@0PrashantYadav0 0PrashantYadav0 commented Aug 1, 2026

Copy link
Copy Markdown
Member

Resolves #13836

Description

Update WASM binaries and improve performance for strided operations

  • Updated the binary and WebAssembly text format (WAT) for sapxsumkbn, enhancing the efficiency of the summation algorithm.
  • Modified the binary and WAT for dmeanors, optimizing the mean calculation process.
  • Improved the binary and WAT for dmeanpw, refining the weighted mean computation.
  • Adjusted base64 encoded strings in the browser binary files to reflect the latest changes in the WASM modules.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues: #13836

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@0PrashantYadav0
0PrashantYadav0 requested a review from a team August 1, 2026 14:29
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 1, 2026
@0PrashantYadav0 0PrashantYadav0 changed the title feat: Update WASM binaries and improve performance for strided operations fix: Update WASM binaries and improve performance for strided operations Aug 1, 2026
@0PrashantYadav0 0PrashantYadav0 changed the title fix: Update WASM binaries and improve performance for strided operations fix: Update WASM binaries for recently updated packages Aug 1, 2026
@0PrashantYadav0
0PrashantYadav0 marked this pull request as draft August 1, 2026 14:50
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 1, 2026
@0PrashantYadav0
0PrashantYadav0 marked this pull request as ready for review August 2, 2026 05:22
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 2, 2026
@0PrashantYadav0

0PrashantYadav0 commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

@kgryte Currently, the tests are failing due to incorrect expected values from the new Wasm binaries. I've opened a new PR for the test cases (#13855). Since both PRs depend on each other to pass the CI checks, should I combine them into one? I've kept them separate for now and will wait for your feedback before moving forward.

@0PrashantYadav0 0PrashantYadav0 changed the title fix: Update WASM binaries for recently updated packages fix: update wasm binaries for recently updated packages Aug 2, 2026
@kgryte

kgryte commented Aug 2, 2026

Copy link
Copy Markdown
Member

I am a bit confused. Why are we needing to update the Wasm binaries? Did you build with the latest Emscripten and this resulted in different binaries?

@kgryte

kgryte commented Aug 2, 2026

Copy link
Copy Markdown
Member

It is also a bit odd that a number of the binaries grew in size.

@kgryte

kgryte commented Aug 2, 2026

Copy link
Copy Markdown
Member

How did you generate them? And how did you install upstream deps, such as Emscripten?

@0PrashantYadav0

0PrashantYadav0 commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

The Wasm updates are strictly from a toolchain rebuild, not C algorithm changes ( they reflect the changes in c algo, if there is any ) . I installed Emscripten via make install-deps-emsdk (DEPS_EMSDK_VERSION=latest, which is currently 6.0.5) and regenerated the binaries using make wasm. The file sizes fluctuated (28 are smaller, 10 are larger) because the newer LLVM/Emscripten produces different codegen (e.g., more loop unrolling); the net change is only ~+743 bytes.

Also, a few modules have changes that are not yet reflected in the Wasm binaries, which is causing some tests to fail. For reference, the changes introduced in commit 981c7ba need to be included in the Wasm packages

@0PrashantYadav0

0PrashantYadav0 commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

To resolve the failing tests, I regenerated the wasm binaries with the latest source changes. This update accounts for the size increase in a few of the binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Update WASM binaries for recently updated packages

3 participants

@0PrashantYadav0 @kgryte @stdlib-bot