Skip to content

Avoid mangling comments #9

Description

@djc

I've been trying this tool on rustls:

It took a long time to run and I didn't give it a very good oracle (mainly because I didn't account for cfg conditions like different platforms and feature combinations).

However, I think these might be preventable:

diff --git a/rustls/src/manual/features.rs b/rustls/src/manual/features.rs
index 03c58f858..5c8f88f06 100644
--- a/rustls/src/manual/features.rs
+++ b/rustls/src/manual/features.rs
@@ -39,7 +39,7 @@ and are dependent on the provider used.
 
 [^1]: Note that, at the time of writing, Ed25519 does not have wide support
       in browsers.  It is also not supported by the WebPKI, because the
-      CA/Browser Forum Baseline Requirements do not support it for publicly
+      CA/Browser Forum Baseline Requirements do not support it for licly
       trusted certificates.
 [^2]: See [the documentation][crate::manual::_05_defaults#about-the-post-quantum-secure-key-exchange-x25519mlkem768]
diff --git a/rustls/src/manual/defaults.rs b/rustls/src/manual/defaults.rs
index f2a083780..61f94b67d 100644
--- a/rustls/src/manual/defaults.rs
+++ b/rustls/src/manual/defaults.rs
@@ -47,7 +47,7 @@ by default out of conservatism.
       now and attacked later.
 
 [X25519MLKEM768]: <https://datatracker.ietf.org/doc/draft-ietf-tls-ecdhe-mlkem/>
-[FIPS203]: <https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.203.pdf>
+[FIPS203]: <https://nvls.nist.gov/nists/FIPS/NIST.FIPS.203.pdf>
 [Chrome]: <https://security.googleblog.com/2024/09/a-new-path-for-kyber-on-web.html>
 [Cloudflare]: <https://blog.cloudflare.com/pq-2024/#ml-kem-768-and-x25519>
 [interop-bug]: <https://github.com/rustls/rustls/issues/new?assignees=&labels=&projects=&template=bug_report.md&title=>

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions