You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add [async] optional dependencies to pyproject.toml so users can install async requirements with pip install "slack-bolt[async]" instead of manually installing aiohttp.
Changes:
Add optional-dependencies.async to pyproject.toml (references existing requirements/async.txt)
Update install instructions in README.md, docs/, and slack_bolt/async_app.py docstring
Category
slack_bolt.App and/or its core components
slack_bolt.async_app.AsyncApp and/or its core components
Adapters in slack_bolt.adapter
Document pages under /docs
Others
Requirements
I've read and understood the Contributing Guidelines and have done my best effort to follow them.
Currently we recommend running pip install slack_bolt aiohttp to use the AsyncApp, making pip install "slack_bolt[async]" reference the import in requirements/async.txt may not be the desired behavior as requirements/async.txt is intended for testing.
We might want to think more about this strategy before implementing a slack_bolt[async] 🤔 since it means that this project would support specific versions of aiohttp and bumping the minimum version may result in breaking changes here
That's a fair point — I hadn't considered the maintenance cost of supporting specific aiohttp versions as optional dependencies. Bumping the minimum version could indeed introduce breaking changes, which adds ongoing burden to the maintainers.
I was inspired by python-slack-sdk's optional.txt and thought a similar approach could work here, but I understand that the context is different — requirements/async.txt in bolt-python is intended for testing, not for end-user dependency management.
I'll go ahead and close this PR. Thanks again for the thoughtful feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
[async]optional dependencies topyproject.tomlso users can install async requirements withpip install "slack-bolt[async]"instead of manually installingaiohttp.Changes:
optional-dependencies.asynctopyproject.toml(references existingrequirements/async.txt)README.md,docs/, andslack_bolt/async_app.pydocstringCategory
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.