feat(quickbooks): add accountant-focused financial reports - #6197
feat(quickbooks): add accountant-focused financial reports#6197BillLeoutsakosvl346 wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Read Master Data now includes Class and Department record types (with Block wiring maps UI sub-blocks to tool params via a per-report control matrix; unsupported combinations are omitted before the API call. Docs, Reviewed by Cursor Bugbot for commit fc1bfdc. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR adds a bounded QuickBooks financial-report operation covering 14 report types and extends master-data discovery with Class and Department.
Confidence Score: 5/5The PR appears safe to merge after its stated parent branch, with no concrete changed-code failure identified. The report operation is consistently wired through the block, registry, request builder, response contract, generated metadata, documentation, and tests, while unsupported controls are rejected or discarded before the outbound request.
|
| Filename | Overview |
|---|---|
| apps/sim/tools/quickbooks/utils.ts | Adds the fixed report matrix, validation, URL construction, native response transformation, and Class/Department entity mappings without an accepted defect. |
| apps/sim/tools/quickbooks/run_financial_report.ts | Defines a bounded OAuth-backed GET tool with retries disabled, an 8 MiB response limit, and structured native report outputs. |
| apps/sim/blocks/blocks/quickbooks.ts | Adds report-specific controls, visibility rules, post-resolution parameter coercion, stale-control filtering, and conditional outputs. |
| apps/sim/tools/quickbooks/types.ts | Adds report, Class, and Department contracts plus nested output metadata aligned with the new operation. |
| apps/sim/tools/quickbooks/read_master_data.ts | Extends the existing master-data reader to expose Class and Department through the established list and by-ID paths. |
| apps/sim/tools/quickbooks/reports.test.ts | Covers all report endpoints, supported controls, validation failures, output preservation, response limits, UI conditions, and master-data discovery. |
| apps/sim/tools/registry.ts | Registers the new financial-report tool consistently with the block access list and QuickBooks barrel export. |
| apps/docs/content/docs/en/integrations/quickbooks.mdx | Documents report inputs, native outputs, Class/Department discovery, and the intended performance guidance. |
Sequence Diagram
sequenceDiagram
participant Workflow
participant Block as QuickBooks Block
participant Tool as Financial Report Tool
participant QBO as QuickBooks Online
Workflow->>Block: report type and supported controls
Block->>Block: resolve values, coerce aging days, discard stale controls
Block->>Tool: normalized report parameters and OAuth credential
Tool->>Tool: validate support matrix and construct fixed URL
Tool->>QBO: bounded GET, retries disabled
QBO-->>Tool: native Header, Columns, Rows
Tool->>Tool: validate report wrapper
Tool-->>Workflow: preserved native report output
Reviews (1): Last reviewed commit: "feat(quickbooks): expose reports in bloc..." | Re-trigger Greptile
68cbb1d to
ccc6701
Compare
f788487 to
4f2eea3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1edbb50. Configure here.
ccc6701 to
2b6202c
Compare
1edbb50 to
33d4ad2
Compare
2b6202c to
afdc799
Compare
33d4ad2 to
fc1bfdc
Compare

Summary
Scope decisions
GeneralLedgerDetailSafety
minorversion=75, sandbox/production host selection, OAuth headers, fault handling, and 8 MiB response cap are reusedValidation
gpt-5.6-solhigh-reasoning full-stack review againststaging: no actionable findingsgit diff --checkStack
feat/quickbooks-04a-po-bill-linking