Skip to content

feat(quickbooks): add general accounting operations - #6185

Open
BillLeoutsakosvl346 wants to merge 6 commits into
feat/quickbooks-03-payablesfrom
feat/quickbooks-04-accounting
Open

feat(quickbooks): add general accounting operations#6185
BillLeoutsakosvl346 wants to merge 6 commits into
feat/quickbooks-03-payablesfrom
feat/quickbooks-04-accounting

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Adds a bounded accounting reader for journal entries, deposits, and transfers.
  • Adds explicit create/update tools for journal entries and deposits.
  • Exposes 39 total QuickBooks operations with direct block, tool, and registry parity.
  • Keeps transfers read-only and updates header-only.

Safety and validation

  • Journal entries require explicit posting confirmation and exact balanced integer-cent totals.
  • No arbitrary queries, raw payloads, retries, fan-out, automatic pagination, currency controls, or API routes.
  • 570 accumulated tests pass, plus type-check, format, lint, API validation, bare-icon, client-boundary, tool-metadata, generated-doc, and memory-bound checks.
  • Independent GPT-5.6 Sol high review against the fixed staging comparison found no actionable issues.

Manual acceptance

Live authenticated sandbox execution could not be automated because this environment had no controllable signed-in browser. Request contracts and transformations are covered by sanitized fixtures and the complete local suite.

Stacked on feat/quickbooks-03-payables. Never merge automatically.

@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 3, 2026 7:42am

Request Review

@cursor

cursor Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Journal entries and deposits post directly to live QuickBooks books; explicit posting confirmation and balanced-line validation reduce accidental writes, but mistakes still affect financial records.

Overview
Extends the QuickBooks block and docs with general accounting workflows alongside existing sales and purchasing coverage, bringing the integration to 39 operations.

New capabilities include Read Accounting Transactions (list or by-ID for journal entries, deposits, and read-only transfers) and create/update tools for journal entries and deposits. The block adds matching operation dropdown entries, an accounting transaction-type selector, JSON fields for journal and deposit lines (with wand prompts), and a Confirm Posting gate on journal create/update. Parameter mapping uses accounting_utils parsers and folds accounting reads into the same pagination and list-output patterns as other transaction readers.

Descriptions in integrations.json and the QuickBooks docs page are updated for accounting scope. A workflow template and skill content shift from credit/refund review to journal adjustments and deposits; parseConfirmation now accepts a field name for clearer validation errors.

Reviewed by Cursor Bugbot for commit d15b309. Bugbot is set up for automated code reviews on this repo. Configure here.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai

@greptile-apps

greptile-apps Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds bounded QuickBooks journal-entry, deposit, and transfer reading plus create/update operations for journal entries and deposits.

  • Adds strict journal/deposit line parsing, balanced integer-cent validation, posting confirmation, and sparse header-only updates.
  • Registers five accounting tools and wires them through the QuickBooks block, generated metadata, registry, documentation, and tests.
  • Keeps transfer support read-only and disables automatic retries and pagination.

Confidence Score: 5/5

The PR appears safe to merge from a code-review perspective, with no actionable changed-code defects identified.

The accounting operations use fixed entity mappings, bounded validated inputs, exact journal balancing, explicit posting confirmation, header-only sparse updates, and registry/block parity without a concrete reachable failure remaining.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/quickbooks.ts Adds accounting operation UI, conditional inputs, parameter coercion, tool access, and output visibility with registry parity.
apps/sim/tools/quickbooks/accounting_utils.ts Implements bounded line parsing, exact journal balancing, posting confirmation, and create/sparse-update payload builders.
apps/sim/tools/quickbooks/read_accounting_transactions.ts Adds fixed list and by-ID reads for journal entries, deposits, and transfers using shared response transformers.
apps/sim/tools/quickbooks/create_journal_entry.ts Adds a non-retrying authenticated journal-entry creation tool with bounded response handling.
apps/sim/tools/quickbooks/create_deposit.ts Adds a non-retrying authenticated deposit creation tool with validated account lines.
apps/sim/tools/quickbooks/update_journal_entry.ts Adds confirmed sparse journal-entry header updates using ID and sync token.
apps/sim/tools/quickbooks/update_deposit.ts Adds sparse deposit header updates using ID and sync token.
apps/sim/tools/quickbooks/accounting.test.ts Covers entity mappings, response transformations, line validation, payload construction, confirmation, sparse updates, and block parity.
apps/sim/tools/quickbooks/types.ts Extends QuickBooks transaction types and output schemas for general-accounting records.
apps/sim/tools/registry.ts Registers all five new accounting tools consistently with block access and barrel exports.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Block[QuickBooks block] --> Params[Resolve and validate parameters]
  Params --> Reader[Read accounting transactions]
  Params --> Journal[Create or update journal entry]
  Params --> Deposit[Create or update deposit]
  Reader --> Types{Transaction type}
  Types --> JE[JournalEntry]
  Types --> DP[Deposit]
  Types --> TR[Transfer - read only]
  Journal --> QBO[QuickBooks Online API]
  Deposit --> QBO
  JE --> QBO
  DP --> QBO
  TR --> QBO
Loading

Reviews (1): Last reviewed commit: "fix(quickbooks): balance journal entries..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant