Prep 2.0.0 - #778
Merged
Merged
Prep 2.0.0#778
Conversation
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Sep 26, 2023
woodruffw
marked this pull request as ready for review
September 26, 2023 22:02
Member
Author
|
This should be safe to merge whenever; we can create the release anytime after it's merged. |
jku
approved these changes
Sep 27, 2023
jku
left a comment
Member
There was a problem hiding this comment.
LGTM.
For reference on that pydantic issue
- I believe FieldValidationInfo still works but the way they marked it deprecated (which seems to be what happened last friday) is what mypy flags as suspicious
- the fix here looks right to me
woodruffw
enabled auto-merge (squash)
September 28, 2023 18:24
di
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until we're ready to merge this.