Skip to content

Commit d3c1ac7

Browse files
author
Sheldon Hull
committed
version string parsing fails due to using simple 3 part semvar. Removed this needless cast
1 parent c03cdbc commit d3c1ac7

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎templates/PSFProject-sheldonh/build/functions/Update-Version.ps1‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function Update-Version
7979
{
8080
#[version]$ModuleCurrentVersion = '1.0.0.1'
8181
$moduleInformation = Import-PowershellDataFile $PSD1FullName -Verbose:$false | ConvertHashtableTo-Object
82-
[Version]$ModuleOriginalVersion = [version]::parse($Moduleinformation.ModuleVersion)
82+
#[Version]$ModuleOriginalVersion = [version]::parse($Moduleinformation.ModuleVersion)
8383
#[version]::TryParse(('{0}.{1}.{2}.0' -f $moduleInformation.Version.Major, $moduleInformation.Version.Minor, $moduleInformation.Version.Patch), [ref]$ModuleCurrentVersion)
8484
try
8585
{
@@ -90,11 +90,11 @@ function Update-Version
9090
ErrorAction = 'continue'
9191
}
9292
Update-ModuleManifest @SplatMe
93-
Write-PSFMessage -Level Verbose -Message "$ModuleName -- psd1 --$($ModuleOriginalVersion) vs $NewVersion"
93+
Write-PSFMessage -Level Verbose -Message "$ModuleName -- psd1 --$($Moduleinformation.ModuleVersion) vs $NewVersion"
9494
}
9595
catch
9696
{
97-
Write-PSFMessage -Level Warning -Message "FAILED: $ModuleName -- psd1 --$($ModuleOriginalVersion) vs $NewVersion" -Exception $_.Exception
97+
Write-PSFMessage -Level Warning -Message "FAILED: $ModuleName -- psd1 --$($Moduleinformation.ModuleVersion) vs $NewVersion" -Exception $_.Exception
9898
}
9999
}
100100

‎templates/PSFProject-vsts-task/build/functions/Update-Version.ps1‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function Update-Version
7979
{
8080
#[version]$ModuleCurrentVersion = '1.0.0.1'
8181
$moduleInformation = Import-PowershellDataFile $PSD1FullName -Verbose:$false | ConvertHashtableTo-Object
82-
[Version]$ModuleOriginalVersion = [version]::parse($Moduleinformation.ModuleVersion)
82+
#[Version]$ModuleOriginalVersion = [version]::parse($Moduleinformation.ModuleVersion)
8383
#[version]::TryParse(('{0}.{1}.{2}.0' -f $moduleInformation.Version.Major, $moduleInformation.Version.Minor, $moduleInformation.Version.Patch), [ref]$ModuleCurrentVersion)
8484
try
8585
{
@@ -90,11 +90,11 @@ function Update-Version
9090
ErrorAction = 'continue'
9191
}
9292
Update-ModuleManifest @SplatMe
93-
Write-PSFMessage -Level Verbose -Message "$ModuleName -- psd1 --$($ModuleOriginalVersion) vs $NewVersion"
93+
Write-PSFMessage -Level Verbose -Message "$ModuleName -- psd1 --$($Moduleinformation.ModuleVersion) vs $NewVersion"
9494
}
9595
catch
9696
{
97-
Write-PSFMessage -Level Warning -Message "FAILED: $ModuleName -- psd1 --$($ModuleOriginalVersion) vs $NewVersion" -Exception $_.Exception
97+
Write-PSFMessage -Level Warning -Message "FAILED: $ModuleName -- psd1 --$($Moduleinformation.ModuleVersion) vs $NewVersion" -Exception $_.Exception
9898
}
9999
}
100100

0 commit comments

Comments
 (0)