Enable SVG geometric properties for Servo - #427
Merged
Merged
Conversation
Signed-off-by: Mohamed Mostafa <[email protected]>
mu-mostafa98
marked this pull request as ready for review
July 16, 2026 09:15
jdm
approved these changes
Jul 16, 2026
pull Bot
pushed a commit
to AKJUS/servo
that referenced
this pull request
Jul 17, 2026
…tural elements (servo#46558) ## Create DOM element types for SVG shapes, gradients, and structural elements ### SVG Dom Elements hierarchy ``` SVGElement |── SVGGradientElement | ├── SVGLinearGradientElement ← <linearGradient> | └── SVGRadialGradientElement ← <radialGradient> | |── SVGStopElement ← <stop> | |── SVGGraphicsElement | ├── SVGGElement ← <g> | ├── SVGDefsElement ← <defs> | ├── SVGSymbolElement ← <symbol> | ├── SVGUseElement ← <use> | ├── SVGImageElement ← <image> (existing) | ├── SVGSVGElement ← <svg> (existing) | |── SVGGeometryElement ├── SVGCircleElement ← <circle> ├── SVGEllipseElement ← <ellipse> ├── SVGLineElement ← <line> ├── SVGPathElement ← <path> ├── SVGPolygonElement ← <polygon> ├── SVGPolylineElement ← <polyline> └── SVGRectElement ← <rect> ``` ## Presentational hints Added attribute-to-CSS mapping per element type: | Attribute(s) | Element(s) | CSS property | |---|---|---| | `cx`, `cy`, `r` | `<circle>` | `cx`, `cy`, `r` | | `cx`, `cy`, `rx`, `ry` | `<ellipse>` | `cx`, `cy`, `rx`, `ry` | | `x`, `y`, `width`, `height`, `rx`, `ry` | `<rect>` | `x`, `y`, `width`, `height`, `rx`, `ry` | | `x`, `y`, `width`, `height` | `<image>` | `x`, `y`, `width`, `height` | | `d` | `<path>` | `d` (wrapped in `path()` CSS syntax) | | `display`, `visibility`, `opacity` | all SVG | `display`, `visibility`, `opacity` | ## Stylo [PR](servo/stylo#427) --------- Signed-off-by: Mohamed Mostafa <[email protected]>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 2, 2026
…yle-system-reviewers,emilio This imports servo/stylo#427 Removes `engine = "gecko"` from 8 SVG-geometric properties to be enabled for servo: - `x` - `y` - `cx` - `cy` - `rx` - `ry` - `r` - `d` Differential Revision: https://phabricator.services.mozilla.com/D322773
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Sep 3, 2026
…yle-system-reviewers,emilio This imports servo#427 Removes `engine = "gecko"` from 8 SVG-geometric properties to be enabled for servo: - `x` - `y` - `cx` - `cy` - `rx` - `ry` - `r` - `d` Differential Revision: https://phabricator.services.mozilla.com/D322773
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
engine = "gecko"from 8 SVG-geometric properties to be enabled for servo:xycxcyrxryrdServo PR