Also update AnimationState::Paused in Animation::update_from_other if delay changes - #422
Merged
Merged
Conversation
Member
Author
|
Servo PR for this incoming. |
mrobinson
force-pushed
the
also-update-paused-state
branch
from
July 21, 2026 12:38
0c2e685 to
727c97b
Compare
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Jul 21, 2026
…m_other` if delay changes This incorporates servo/stylo#422 and adds a test case. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
mrobinson
marked this pull request as ready for review
July 21, 2026 12:49
Member
Author
|
This is ready for review cc @yezhizhen . |
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 21, 2026
…m_other` if delay changes This incorporates servo/stylo#422 and adds a test case. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
yezhizhen
approved these changes
Jul 21, 2026
| self.started_at = old_started_at + (self.delay - old_delay); | ||
|
|
||
| match old_state { | ||
| Paused(old_progress) => { |
| }, | ||
| _ => { | ||
| // Running or Pending — re-advance iterations from a fresh | ||
| // Running, Pending, or Paused — re-advance iterations from a fresh |
Member
There was a problem hiding this comment.
Suggested change
| // Running, Pending, or Paused — re-advance iterations from a fresh | |
| // Running or Pending — re-advance iterations from a fresh |
This can't be paused. We are talking about old state.
Member
Author
There was a problem hiding this comment.
Hrm. Good point. The original comment neglected to include Canceled here, so I've converted this code to use an explicit match instead of a wildcard, which is slightly more self-documenting.
| _ => {}, | ||
| } | ||
| self.iterate_by(starting_progress); | ||
| if let AnimationState::Paused(ref mut starting_progress) = &mut self.state { |
Member
There was a problem hiding this comment.
Here we are talking about new state, which contain the case going from Playing to Paused.
…` if delay changes If the delay in an animation changes, we still might need to update the `Paused` state if the animation is moving from `Playing` to `Paused`. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
also-update-paused-state
branch
from
July 22, 2026 20:21
727c97b to
20e846c
Compare
Member
Author
|
@yezhizhen Thanks for the review. |
mrobinson
enabled auto-merge
July 22, 2026 20:21
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Jul 23, 2026
…m_other` if delay changes This incorporates servo/stylo#422 and adds a test case. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 23, 2026
…m_other` if delay changes This incorporates servo/stylo#422 and adds a test case. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
servo-wpt-sync
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2026
…m_other` if delay changes This incorporates servo/stylo#422 and adds a test case. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Jul 23, 2026
…m_other` if delay changes (#46689) This incorporates servo/stylo#422 and adds a test case. Testing: This change adds a WPT crashtest. Fixes: #46335. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jul 24, 2026
…ed` in `Animation::update_from_other` if delay changes, a=testonly Automatic update from web-platform-tests stylo: Also update `AnimationState::Paused` in `Animation::update_from_other` if delay changes This incorporates servo/stylo#422 and adds a test case. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Oriol Brufau <[email protected]> -- wpt-commits: ace47e783b5bb7f3a16f002707de5e4c8e31a9e7 wpt-pr: 61440
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 2, 2026
…ate_from_other` if delay changes. r=firefox-style-system-reviewers,emilio This imports servo/stylo#422 If the delay in an animation changes, we still might need to update the `Paused` state if the animation is moving from `Playing` to `Paused`. Differential Revision: https://phabricator.services.mozilla.com/D322776
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Sep 3, 2026
…ate_from_other` if delay changes. r=firefox-style-system-reviewers,emilio This imports servo#422 If the delay in an animation changes, we still might need to update the `Paused` state if the animation is moving from `Playing` to `Paused`. Differential Revision: https://phabricator.services.mozilla.com/D322776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the delay in an animation changes, we still might need to update the
Pausedstate if the animation is moving fromPlayingtoPaused.Servo PR: servo/servo#46689