Conversation
7 tasks
This is the first simplification from servo#47294. It moves `BrowsingContextGroup` to `ConstellationWebView`. Every WebView has a single `BrowsingContextGroup`, but this group might be shared between `WebView`s. This is enforced by keeping groups in an `Rc<RefCell<..>>` -- the shared ownership reflecting the reality of the specification. In addition, this change fixes a leak of `WebGPU` threads that happened when a `WebView` was destroyed before shutdown. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
constellation-move-browsing-context-group-to-webview
branch
from
September 13, 2026 07:07
7528cdc to
492a655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first simplification from #47294. It moves
BrowsingContextGrouptoConstellationWebView. Every WebView has asingle
BrowsingContextGroup, but this group might be shared betweenWebViews. This is enforced by keeping groups in anRc<RefCell<..>>-- the shared ownership reflecting the reality of the specification.
In addition, this change fixes a leak of
WebGPUthreads that happenedwhen a
WebViewwas destroyed before shutdown.Testing: This should not change behavior (other than the leak fix, which
is difficult to test) so is covered by existing tests.
Fixes: This is part of #47294.