script: Ignore http status code error in image fetching - #46892
Merged
Merged
Conversation
Signed-off-by: YodaLee <[email protected]>
Signed-off-by: YodaLee <[email protected]>
Contributor
Author
|
This PR contain only clean commits that created with "git commit -s" without rebase. Also I remove the space inside my name. See if this time it works. |
jdm
approved these changes
Jul 30, 2026
Member
|
There was an upstream issue in the DCO app that has now been fixed, so this should work correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the issue, this PR simplified the status in HTMLImageElement.
In image fetching, the returned HTTP status code is no longer checked.
As long as the image data can be successfully decoded
an error HTML like 404 will be ignored, and set the status to Ok(())
Testing: After this change, there are two test cases in wpt that respond 404 while fetching image will become PASS.
Fixes: #46696