fetch: Add support for Request::duplex - #46858
Conversation
Signed-off-by: Taym Haddadi <[email protected]>
|
🔨 Triggering try run (#30445717201) for Linux (WPT) |
|
Test results for linux-wpt from try job (#30445717201): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (23)
Stable unexpected results (12)
|
|
|
|
🔨 Triggering try run (#30450052421) for Linux (WPT) |
|
|
|
🔨 Triggering try run (#30489345411) for Linux (WPT) |
|
Test results for linux-wpt from try job (#30489345411): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (13)
Stable unexpected results (3)
|
|
|
Signed-off-by: Taym Haddadi <[email protected]>
0c6b166 to
11c137c
Compare
Request::duplex
mrobinson
left a comment
There was a problem hiding this comment.
Looks good, but maybe we can split out the BodySink changes?
I can separate it. I just saw an issue, and I thought maybe I can also fix it. |
|
Actually my goal of this PR was not duplex but "Implement HTTP/2 ReadableStream request uploads" I added duplex since was small. |
Signed-off-by: Taym Haddadi <[email protected]>
|
created #46888 |
|
🔨 Triggering try run (#30540198936) for Linux (WPT) |
|
Test results for linux-wpt from try job (#30540198936): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (21)
|
|
✨ Try run (#30540198936) succeeded. |
fetch: fix HTTP/2 ReadableStream request uploads drop BodySink after the request body stream completes or errors, preventing further writes and allowing HTTP/2 uploads to finish. Testing: tests/wpt/meta/fetch/api/basic/request-upload.h2.any.js.ini depends on servo#46858 Signed-off-by: Taym Haddadi <[email protected]>
Testing: This causes WPT subtests related to
Request::duplexto start passing.