script: Fix borrow hazard when resolving XRSession end promises - #46830
Merged
Merged
Conversation
Before, end_promises was drained when calling resolve_native() while holding a borrow. Rewritten to resolve the promises before clearing the list. Fixes servo#46715. Signed-off-by: Amit Anilkumar <[email protected]>
Narfinger
approved these changes
Jul 28, 2026
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, end_promises was drained while holding a mutable borrow during resolve_native(). Rewrote to resolve each promise reading from an immutable borrow, and then clearing the list after.
Testing:
.\mach build -r: to test if borrow fixed in compile-time.\mach test-wpt -r tests/wpt/tests/webxr/: no change in test results, when comparing with main branchFixes #46715.