Skip to content

script: Expose id to LargestContentfulPaint - #46828

Merged
jdm merged 2 commits into
servo:mainfrom
shubhamg13:lcp_id_new
Jul 31, 2026
Merged

jdm merged 2 commits into
servo:mainfrom
shubhamg13:lcp_id_new

Conversation

@shubhamg13

Copy link
Copy Markdown
Member

Expose id to LargestContentfulPaint

Testing: More WPT Passed
Fixes: Part of #42000

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 28, 2026

@mrobinson mrobinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure happy with the way the element id is stored in the fragment tree, but this whole thing also depends on script having access to the Element itself as well. If that happens successfully we don't actually need to roundtrip the element id string into the fragment tree. Still, I'm not sure I understand how we can get the Element safely.

@shubhamg13
shubhamg13 marked this pull request as draft July 29, 2026 01:35
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@shubhamg13

Copy link
Copy Markdown
Member Author

I'm not sure happy with the way the element id is stored in the fragment tree, but this whole thing also depends on script having access to the Element itself as well. If that happens successfully we don't actually need to roundtrip the element id string into the fragment tree. Still, I'm not sure I understand how we can get the Element safely.

Id is resolved now using Element.

@shubhamg13
shubhamg13 marked this pull request as ready for review July 31, 2026 01:15
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 31, 2026
@jdm
jdm added this pull request to the merge queue Jul 31, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 31, 2026
Merged via the queue into servo:main with commit 86465d6 Jul 31, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 31, 2026
@shubhamg13
shubhamg13 deleted the lcp_id_new branch July 31, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants