layout: Simplify the way that document selection is handled in traversals - #46762
Merged
Merged
Conversation
…sals Instead of eagerly passing the document selection range in the DOM traveral, only fetch it when necessary before pushing text into an `InlineFormattingContextBuilder`. This greatly simplifies the traversal handler signatures and makes the code more straight-foward in other places as well (removing ~70 lines of code). Signed-off-by: Martin Robinson <[email protected]>
jdm
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of eagerly passing the document selection range in the DOM
traveral, only fetch it when necessary before pushing text into an
InlineFormattingContextBuilder. This greatly simplifies the traversalhandler signatures and makes the code more straight-foward in other
places as well (removing ~70 lines of code).
Testing: This should not change behavior so is covered by existing tests.