script: Address borrow hazard in DocumentEventHandler::handle_touch_event - #46693
Merged
Merged
Conversation
Signed-off-by: Josh Matthews <[email protected]>
mrobinson
approved these changes
Jul 21, 2026
mrobinson
left a comment
Member
There was a problem hiding this comment.
It's like we are living the future. :)
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
jdm
force-pushed
the
document-event-handler-hazard
branch
from
July 21, 2026 16:15
cea130c to
54e99a0
Compare
jdm
enabled auto-merge
July 21, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing uses of borrow_mut with safe_borrow_mut in DocumentEventHandler exposed a borrow hazard. This is addressed by scoping the mutable borrow to the code that requires mutation.
Testing: Existing tests suffice.
Fixes: part of #40600