Skip to content

stylo: Also update AnimationState::Paused in Animation::update_from_other if delay changes - #46689

Merged
mrobinson merged 1 commit into
servo:mainfrom
mrobinson:animation-panic
Jul 23, 2026
Merged

mrobinson merged 1 commit into
servo:mainfrom
mrobinson:animation-panic

Conversation

@mrobinson

Copy link
Copy Markdown
Member

This incorporates servo/stylo#422 and adds a test case.

Testing: This change adds a WPT crashtest.
Fixes: #46335.

@servo-wpt-sync

Copy link
Copy Markdown
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#61440) with upstreamable changes.

@servo-wpt-sync

Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#61440).

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 21, 2026
…m_other` if delay changes

This incorporates servo/stylo#422 and adds a test case.

Signed-off-by: Martin Robinson <[email protected]>
Co-authored-by: Oriol Brufau <[email protected]>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 23, 2026
@mrobinson
mrobinson enabled auto-merge July 23, 2026 07:19
@servo-wpt-sync

Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#61440).

@mrobinson
mrobinson added this pull request to the merge queue Jul 23, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 23, 2026
Merged via the queue into servo:main with commit 81a9dab Jul 23, 2026
34 checks passed
@mrobinson
mrobinson deleted the animation-panic branch July 23, 2026 08:58
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 23, 2026
ken7253 pushed a commit to ken7253/stylo that referenced this pull request Jul 27, 2026
…` if delay changes (servo#422)

If the delay in an animation changes, we still might need to update the
`Paused` state if the animation is moving from `Playing` to `Paused`.

Servo PR: servo/servo#46689

Signed-off-by: Martin Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

4 participants