fonts: Support font-language-override - #46618
Merged
Merged
Conversation
simonwuelker
force-pushed
the
font-language-override
branch
from
July 18, 2026 19:48
02927ea to
8450d0d
Compare
simonwuelker
commented
Jul 18, 2026
| let font_style = parent_style.clone_font(); | ||
| let language = font_style._x_lang.0.parse().unwrap_or(Language::UND); | ||
| let language_for_shaping = Some(font_style.font_language_override) | ||
| .filter(|language_override| *language_override != FontLanguageOverride::normal()) |
Member
Author
There was a problem hiding this comment.
We differentiate between language and language_for_shaping here because it is my understanding that font-language-override should not affect font selection. The specification is not really explicit about that though: https://drafts.csswg.org/css-fonts/#font-language-override-prop
|
🔨 Triggering try run (#29658548113) for Linux (WPT) |
|
Test results for linux-wpt from try job (#29658548113): Flaky unexpected result (43)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (4)
|
|
|
simonwuelker
marked this pull request as ready for review
July 18, 2026 22:34
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
font-language-override
branch
from
July 18, 2026 23:51
478567d to
536bf9c
Compare
nicoburns
pushed a commit
to nicoburns/stylo
that referenced
this pull request
Jul 19, 2026
Oddly enough the longhand itself was already enabled. Its not yet supported in servo though. Servo PR: servo/servo#46618 Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
font-language-override
branch
from
July 19, 2026 15:34
536bf9c to
4c7b9cc
Compare
simonwuelker
enabled auto-merge
July 19, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: New tests start to pass
Depends on servo/stylo#429