Script: Create DOM element types for SVG shapes, gradients, and structural elements by mu-mostafa98 · Pull Request #46558 · servo/servo

mu-mostafa98 · 2026-07-16T09:00:39Z

Create DOM element types for SVG shapes, gradients, and structural elements

SVG Dom Elements hierarchy

SVGElement
|── SVGGradientElement
|            ├── SVGLinearGradientElement   ← <linearGradient>
|            └── SVGRadialGradientElement   ← <radialGradient>
|
|── SVGStopElement                  ← <stop>
|
|── SVGGraphicsElement
|              ├── SVGGElement                ← <g>
|              ├── SVGDefsElement             ← <defs>
|              ├── SVGSymbolElement           ← <symbol>
|              ├── SVGUseElement              ← <use>
|              ├── SVGImageElement            ← <image> (existing)
|              ├── SVGSVGElement              ← <svg> (existing)
|
|── SVGGeometryElement
              ├── SVGCircleElement      ← <circle>
              ├── SVGEllipseElement     ← <ellipse>
              ├── SVGLineElement        ← <line>
              ├── SVGPathElement        ← <path>
              ├── SVGPolygonElement     ← <polygon>
              ├── SVGPolylineElement    ← <polyline>
              └── SVGRectElement        ← <rect>

Presentational hints

Added attribute-to-CSS mapping per element type:

Attribute(s)	Element(s)	CSS property
`cx`, `cy`, `r`	`<circle>`	`cx`, `cy`, `r`
`cx`, `cy`, `rx`, `ry`	`<ellipse>`	`cx`, `cy`, `rx`, `ry`
`x`, `y`, `width`, `height`, `rx`, `ry`	`<rect>`	`x`, `y`, `width`, `height`, `rx`, `ry`
`x`, `y`, `width`, `height`	`<image>`	`x`, `y`, `width`, `height`
`d`	`<path>`	`d` (wrapped in `path()` CSS syntax)
`display`, `visibility`, `opacity`	all SVG	`display`, `visibility`, `opacity`

Stylo PR

github-actions · 2026-07-16T09:10:49Z

🔨 Triggering try run (#29486140431) for Linux (WPT)

github-actions · 2026-07-16T10:19:46Z

Test results for linux-wpt from try job (#29486140431):

Flaky unexpected result (40)

OK /IndexedDB/idbdatabase_deleteObjectStore.any.html (#43823)
- PASS [expected FAIL] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
OK /IndexedDB/idbdatabase_deleteObjectStore.any.sharedworker.html (#45919)
- PASS [expected FAIL] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
OK /IndexedDB/idbdatabase_deleteObjectStore.any.worker.html (#43776)
- PASS [expected FAIL] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
ERROR [expected OK] /_mozilla/mozilla/img-load-more-than-cache.html
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-06.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-16.html
- NOTRUN [expected PASS] subtest: Overall test
CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/offscreencanvas-query.html
TIMEOUT [expected OK] /_webgl/conformance2/state/gl-object-get-calls.html
- NOTRUN [expected PASS] subtest: Overall test
CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html (#45255)
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 0deg' over 'oblique -50deg -20deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique 5deg' over 'oblique 15deg 20deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#45763)
OK [expected TIMEOUT] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- PASS [expected TIMEOUT] subtest: [keepalive][iframe][load] mixed content redirect; setting up
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html (#44098)
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by formElement.requestSubmit()
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html (#44058)
- PASS [expected FAIL] subtest: Parse errors in different files should be reported depending on different roots
TIMEOUT [expected OK] /html/syntax/parsing/html5lib_write_single.html?file=processing-instructions (#46206)
- TIMEOUT [expected FAIL] subtest: <head><?something>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <html><head></head><?something><body>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <html><body></body></html><?something>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><template><?something></template>
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html (#45151)
- TIMEOUT [expected FAIL] subtest: Post-navigation state reset.
```
Test timed out
```
OK /html/webappapis/dynamic-markup-insertion/document-write/iframe_005.html (#43671)
- PASS [expected FAIL] subtest: document.write external script into iframe write back into parent
OK /infrastructure/testdriver/click_iframe.html
- FAIL [expected PASS] subtest: TestDriver click on a document in an iframe
```
Unhandled rejection: assert_unreached: click failed Reached unreachable code
```
OK /mixed-content/tentative/autoupgrades/video-upgrade.https.sub.html (#41135)
- FAIL [expected PASS] subtest: Video of other host autoupgraded
```
assert_equals: Length. Other host expected 1 but got Infinity
```
ERROR [expected TIMEOUT] /performance-timeline/not-restored-reasons/abort-block-bfcache.window.html (#42802)
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#44693)
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /resource-timing/buffer-full-then-increased.html (#44408)
- PASS [expected FAIL] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event
CRASH [expected OK] /svg/animations/animate-calcMode-spline-from-by.html
CRASH [expected PASS] /svg/painting/marker-with-mask-cycle-crash.html
CRASH [expected OK] /trusted-types/script-enforcement-016.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?16-20 (#44835)
- TIMEOUT [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in enforcing mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a frame via area with javascript:-urls in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in report-only mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
ERROR [expected OK] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (17)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 14 more unexpected results...

OK /beacon/beacon-basic.https.window.html (#41723)
- PASS [expected FAIL] subtest: Payload size restriction should be accumulated: type = arraybuffer
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected ERROR] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT /html/syntax/parsing/html5lib_write.html?file=processing-instructions (#46205)
- TIMEOUT [expected FAIL] subtest: <body><?config-v2 data>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?x>
```
Test timed out
```
OK /paint-timing/with-lcp/fcp-document-opacity-image.html (#43068)
- PASS [expected FAIL] subtest: Test that FCP after opacity change is not a larger value than LCP
OK /pointerevents/pointerevent_pointercapture_in_frame.html?touch (#45445)
- PASS [expected FAIL] subtest: Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture.
- PASS [expected FAIL] subtest: Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture to outer frame should not capture.
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```

OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)

FAIL [expected PASS] subtest: Validate render blocking status of link resources in PerformanceResourceTiming

assert_equals: render blocking status for http://web-platform.test:8000/resource-timing/resources/empty_style.css?stylesheet-head-dynamic-docWrite should be blocking expected (string) "blocking" but got (undefined) undefined

OK /sanitizer-api/sanitizer-inert-document.html (#45260)
- FAIL [expected PASS] subtest: Test whether setHTML loads the image.
```
promise_test: Unhandled rejection with value: "The server observed a request. It shouldn't have."
```
- PASS [expected FAIL] subtest: Test whether setHTMLUnsafe loads the image.
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.

OK /visual-viewport/resize-event-order.html (#41981)

FAIL [expected PASS] subtest: Popup: DOMWindow resize fired before VisualViewport.

assert_equals: expected "window-attribute,window-addEventListener,visualViewport-attribute,visualViewport-addEventListener" but got ""

github-actions · 2026-07-16T10:19:55Z

✨ Try run (#29486140431) succeeded.

jdm

Thanks for breaking this work up across multiple PRs!

Removes `engine = "gecko"` from 8 SVG-geometric properties to be enabled for servo: - `x` - `y` - `cx` - `cy` - `rx` - `ry` - `r` - `d` Servo [PR](servo/servo#46558) Signed-off-by: Mohamed Mostafa <[email protected]>

Signed-off-by: Mohamed Mostafa <[email protected]>

mu-mostafa98 force-pushed the svg-dom-elements branch from efc2457 to 5e604c9 Compare July 16, 2026 09:02

mrobinson added the T-linux-wpt Do a try run of the WPT label Jul 16, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Jul 16, 2026

mu-mostafa98 marked this pull request as ready for review July 16, 2026 09:15

mu-mostafa98 requested a review from gterzian as a code owner July 16, 2026 09:15

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 16, 2026

mu-mostafa98 mentioned this pull request Jul 16, 2026

Enable SVG geometric properties for Servo servo/stylo#427

Merged

mu-mostafa98 force-pushed the svg-dom-elements branch from 2fb8222 to 5ddfad8 Compare July 16, 2026 09:36

jdm approved these changes Jul 16, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 16, 2026

mu-mostafa98 force-pushed the svg-dom-elements branch from 5ddfad8 to b9c6c0f Compare July 16, 2026 12:55

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 16, 2026

mu-mostafa98 force-pushed the svg-dom-elements branch from b9c6c0f to a84ec3b Compare July 16, 2026 13:07

jdm added this pull request to the merge queue Jul 16, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 16, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 16, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 16, 2026

TimvdLippe added this pull request to the merge queue Jul 16, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 16, 2026

TimvdLippe removed this pull request from the merge queue due to a manual request Jul 16, 2026

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 16, 2026

jdm added S-needs-rebase There are merge conflict errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 16, 2026

Create Dom Elements for SVG types

5c7d5df

Signed-off-by: Mohamed Mostafa <[email protected]>

mu-mostafa98 added 2 commits July 17, 2026 09:41

Update manifest

44cc96b

Signed-off-by: Mohamed Mostafa <[email protected]>

Update Stylo

dbf3783

Signed-off-by: Mohamed Mostafa <[email protected]>

mu-mostafa98 force-pushed the svg-dom-elements branch from a84ec3b to dbf3783 Compare July 17, 2026 01:42

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Jul 17, 2026

jdm enabled auto-merge July 17, 2026 01:53

jdm added this pull request to the merge queue Jul 17, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 17, 2026

Merged via the queue into servo:main with commit c701985 Jul 17, 2026
34 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 17, 2026

mu-mostafa98 deleted the svg-dom-elements branch July 17, 2026 05:43

Navigation Menu

Uh oh!

Uh oh!

Script: Create DOM element types for SVG shapes, gradients, and structural elements - #46558

Script: Create DOM element types for SVG shapes, gradients, and structural elements#46558
jdm merged 3 commits into
servo:mainfrom
mu-mostafa98:svg-dom-elements

mu-mostafa98 commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

jdm left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

mu-mostafa98 commented Jul 16, 2026

Create DOM element types for SVG shapes, gradients, and structural elements

SVG Dom Elements hierarchy

Presentational hints

Stylo PR

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

jdm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants