fonts: Deduplicate web font requests to the same URL by simonwuelker · Pull Request #46526 · servo/servo

simonwuelker · 2026-07-15T11:27:16Z

This was supposed to be implemented as part of #46271 but I forgot to hook up the code that actually skips dispatching a new request when there is already one to the same URL.

Testing: This should not change existing behaviour but may reduce intermittency by virtue of making fewer network requests.

github-actions · 2026-07-15T11:27:55Z

🔨 Triggering try run (#29411704534) for Linux (WPT)

github-actions · 2026-07-15T12:03:28Z

Test results for linux-wpt from try job (#29411704534):

Flaky unexpected result (42)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- PASS [expected TIMEOUT] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
FAIL [expected PASS] /_mozilla/css/image-percentage-dimen.html
CRASH [expected OK] /_mozilla/mozilla/iframe-unblock-onload.html
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-14.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-16.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance2/state/gl-object-get-calls.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance2/sync/sync-webgl-specific.html
TIMEOUT [expected OK] /cookies/attributes/domain.sub.html
- TIMEOUT [expected PASS] subtest: Return cookie with valid domain after domain with single dot ('.') value.
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Empty domain treated as host cookie 1
- NOTRUN [expected FAIL] subtest: Empty domain treated as host cookie 2
- NOTRUN [expected PASS] subtest: Empty domain treated as host cookie 3
- NOTRUN [expected PASS] subtest: No host cookies returned for host cookies after non-host redirect 1
- NOTRUN [expected PASS] subtest: No host cookies returned for host cookies after non-host redirect 2
- NOTRUN [expected PASS] subtest: No host cookies returned for host cookies after non-host redirect 3
TIMEOUT [expected OK] /css/compositing/canvas-composite-modes.html
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '351 398' over '501 550'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-stretch: '90%' should prefer '50% 80%' over '60% 70%'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique 0deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -21deg' over 'oblique -60deg -40deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#45763)
TIMEOUT [expected PASS] /css/css-text/text-transform/text-transform-upperlower-025.html
CRASH [expected ERROR] /css/filter-effects/parsing/flood-opacity-invalid.svg
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- FAIL [expected PASS] subtest: moveBefore(): cross-origin iframe is preserved: remove new parent
```
assert_equals: iframe does not fire a second load event expected 1 but got 0
```
- FAIL [expected PASS] subtest: moveBefore(): cross-origin iframe is preserved: remove self via innerHTML
```
assert_equals: iframe does not fire a second load event expected 1 but got 0
```
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.html
- TIMEOUT [expected PASS] subtest: large zstd data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large zstd data should be decompressed successfully with byte stream
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#44099)

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by submitButton.click()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20const%20button%20%3D%20document.createElement(%22button%22)%3B%0A%20%20%20%20button.type%20%3D%20%22submit%22%3B%0A%20%20%20%20form.append(button)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20button.click()%3B%0A%20%20"

TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- PASS [expected FAIL] subtest: traversing history must also traverse hash changes
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected ERROR] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- TIMEOUT [expected PASS] subtest: HTMLMediaElement.srcObject blob
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
CRASH [expected FAIL] /html/semantics/interestfor/interestfor-plain-inline-element.tentative.html
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html (#42419)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#44693)
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
CRASH [expected OK] /trusted-types/TrustedTypePolicyFactory-createPolicy-unenforced.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK /webdriver/tests/classic/accept_alert/accept.py (#43194)
- FAIL [expected PASS] subtest: test_accept_in_popup_window
```
AssertionError: no such alert (404): No user prompt is currently active.
```
OK /webdriver/tests/classic/perform_actions/pointer_touch.py
- FAIL [expected PASS] subtest: test_touch_pointer_in_shadow_tree[inner-open]
```
AssertionError
```
CRASH [expected OK] /webstorage/storage_local_setitem_quotaexceedederr.window.html
ERROR [expected OK] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (18)

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #85

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #87

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #89

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #91

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #101

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #103

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #105

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #107

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

OK /beacon/beacon-basic.https.window.html (#41723)
- PASS [expected FAIL] subtest: Payload size restriction should be accumulated: type = arraybuffer
OK [expected TIMEOUT] /content-security-policy/inheritance/auxiliary-blank-document.html (#44821)
- PASS [expected TIMEOUT] subtest: window.open() inherits CSPs on transient about:blank.
OK [expected TIMEOUT] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- PASS [expected TIMEOUT] subtest: [keepalive][iframe][load] mixed content redirect; setting up
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html (#44028)
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html (#44058)
- PASS [expected FAIL] subtest: Parse errors in different files should be reported depending on different roots
TIMEOUT /html/syntax/parsing/html5lib_write.html?file=processing-instructions (#46205)
- TIMEOUT [expected FAIL] subtest: <body><?hey\rthere=1?>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?hey\x0cthere=1?>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?something ? >
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?something x >
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?something ?\t ??>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?config-v2>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?z0123456789>
```
Test timed out
```
TIMEOUT [expected OK] /infrastructure/testdriver/click_nested.html (#43887)
- NOTRUN [expected FAIL] subtest: TestDriver click method with multiple windows and nested iframe
OK /pointerevents/pointerevent_pointercapture_in_frame.html?touch (#45445)
- PASS [expected FAIL] subtest: Test touchpointer capture in same-origin frame: Pointerdown with set capture at inner frame, then release on next pointermove.
OK /resource-timing/buffer-full-then-increased.html (#44408)
- PASS [expected FAIL] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event
OK /sanitizer-api/sanitizer-inert-document.html (#45260)
- FAIL [expected PASS] subtest: Test whether setHTML loads the image.
```
promise_test: Unhandled rejection with value: "The server observed a request. It shouldn't have."
```
- PASS [expected FAIL] subtest: Test whether setHTMLUnsafe loads the image.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?16-20 (#44835)
- TIMEOUT [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in enforcing mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a frame via area with javascript:-urls in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in report-only mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
- TIMEOUT [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```

OK /visual-viewport/resize-event-order.html (#41981)

FAIL [expected PASS] subtest: Popup: DOMWindow resize fired before VisualViewport.

assert_equals: expected "window-attribute,window-addEventListener,visualViewport-attribute,visualViewport-addEventListener" but got ""

OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- FAIL [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
assert_true: about:blank window opened by 3P iframe does not inherit 3P iframe's StorageKey expected true got false
```

github-actions · 2026-07-15T12:03:35Z

✨ Try run (#29411704534) succeeded.

Signed-off-by: Simon Wülker <[email protected]>

simonwuelker requested a review from nicoburns as a code owner July 15, 2026 11:27

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 15, 2026

simonwuelker added the T-linux-wpt Do a try run of the WPT label Jul 15, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Jul 15, 2026

mrobinson approved these changes Jul 15, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 15, 2026

fonts: Deduplicate web font requests to the same URL

6eb65ee

Signed-off-by: Simon Wülker <[email protected]>

simonwuelker force-pushed the deduplicate-font-requests branch from a37514e to 6eb65ee Compare July 15, 2026 12:08

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 15, 2026

simonwuelker added the A-platform/fonts label Jul 15, 2026

simonwuelker added this pull request to the merge queue Jul 15, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 15, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 15, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 15, 2026

simonwuelker added this pull request to the merge queue Jul 15, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 15, 2026

Merged via the queue into servo:main with commit fe217c9 Jul 15, 2026
44 checks passed

simonwuelker deleted the deduplicate-font-requests branch July 15, 2026 22:30

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 15, 2026

Navigation Menu

Uh oh!

Uh oh!

fonts: Deduplicate web font requests to the same URL - #46526

fonts: Deduplicate web font requests to the same URL#46526
simonwuelker merged 1 commit into
servo:mainfrom
simonwuelker:deduplicate-font-requests

simonwuelker commented Jul 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

simonwuelker commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

simonwuelker commented Jul 15, 2026 •

edited

Loading