layout: Account for nested inline boxes when adjusting floats in RTL inline layout by Loirooriol · Pull Request #46500 · servo/servo

Loirooriol · 2026-07-14T14:40:19Z

Floats are positioned relative to their containing inline formatting context,
but need to be children of their containing inline boxes. This means that
they need their content rectangle offset by the physical distance from the
IFC edge to their containing box. This calculation needs to take into account
directionality. Previously this was a bit buggy and didn't properly take into
account nesting in RTL contexts. This change fixes that.

Testing: 2 tests pass

github-actions · 2026-07-14T14:40:39Z

🔨 Triggering try run (#29341897835) for Linux (WPT)

github-actions · 2026-07-14T15:13:44Z

Test results for linux-wpt from try job (#29341897835):

Flaky unexpected result (37)

CRASH [expected OK] /_webgl/conformance/textures/misc/tex-image-and-sub-image-2d-with-array-buffer-view.html
OK [expected TIMEOUT] /_webgl/conformance/textures/misc/tex-video-using-tex-unit-non-zero.html (#39735)
- PASS [expected NOTRUN] subtest: Overall test
- PASS [expected FAIL] subtest: WebGL test #0
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-06.html
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-07.html
- NOTRUN [expected PASS] subtest: Overall test
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-09.html
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-16.html
TIMEOUT [expected OK] /_webgl/conformance2/sync/sync-webgl-specific.html
CRASH [expected OK] /_webgl/conformance2/transform_feedback/transform_feedback.html
FAIL [expected PASS] /css/css-fonts/font-feature-settings-descriptor-01.html (#45418)

OK /css/css-grid/alignment/grid-self-alignment-stretch-010.html

FAIL [expected PASS] subtest: .grid 1

assert_equals: 
&lt;div class="grid"&gt;
  &lt;div data-offset-x="0" data-offset-y="0" data-expected-width="110" data-expected-height="20" class="firstRowFirstColumn"&gt;XX X&lt;/div&gt;
  &lt;div data-offset-x="120" data-offset-y="0" data-expected-width="80" data-expected-height="110" class="firstRowSecondColumn"&gt;XX X&lt;/div&gt;
  &lt;div data-offset-x="0" data-offset-y="130" data-expected-width="80" data-expected-height="20" class="secondRowFirstColumn"&gt;XX X&lt;/div&gt;
  &lt;div data-offset-x="120" data-offset-y="130" data-expected-width="110" data-expected-height="110" class="secondRowSecondColumn"&gt;XX X&lt;/div&gt;
&lt;/div&gt;
width expected 80 but got 48

FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#45763)
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large zstd data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large zstd data should be decompressed successfully with byte stream
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#44099)

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by submitButton.click()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20const%20button%20%3D%20document.createElement(%22button%22)%3B%0A%20%20%20%20button.type%20%3D%20%22submit%22%3B%0A%20%20%20%20form.append(button)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20button.click()%3B%0A%20%20"

OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- PASS [expected TIMEOUT] subtest: Speed-ups should not change the pitch when preservesPitch=true
- PASS [expected NOTRUN] subtest: Slow-downs should not change the pitch when preservesPitch=true
- TIMEOUT [expected NOTRUN] subtest: Speed-ups should change the pitch when preservesPitch=false
```
Test timed out
```
OK /html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html (#46014)
- FAIL [expected PASS] subtest: seek to currentTime
```
assert_greater_than: seekable ranges expected a number greater than 0 but got 0
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace-set-src.html (#32697)
- PASS [expected FAIL] subtest: Navigating iframe loading='lazy' and then setting src: location.replace
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
CRASH [expected FAIL] /html/semantics/interestfor/interestfor-plain-inline-element.tentative.html
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html (#45151)
- TIMEOUT [expected FAIL] subtest: Post-navigation state reset.
```
Test timed out
```
OK [expected ERROR] /intersection-observer/v2/animated-opacity.html (#40827)
OK /mixed-content/tentative/autoupgrades/audio-upgrade.https.sub.html (#41697)
- FAIL [expected PASS] subtest: Audio of other host autoupgraded
```
assert_equals: Length of other host audio is correct expected 1 but got Infinity
```
OK /paint-timing/fcp-only/fcp-text-input.html
- PASS [expected FAIL] subtest: Text input should become contentful when its value is non-empty
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#44693)
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'

OK /pointerevents/pointerevent_pointercapture_in_frame.html?touch (#45445)

FAIL [expected PASS] subtest: Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture.
```
assert_true: Timed out waiting for lostpointercapture expected true got false
```

FAIL [expected PASS] subtest:

Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture to outer frame should not capture.

assert_array_equals: Received events: innerFrame received pointerdown,innerFrame received pointermove,innerFrame received pointerup,innerFrame received lostpointercapture lengths differ, expected array ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup"] length 3, got ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup", "innerFrame received lostpointercapture"] length 4

OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- FAIL [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
CRASH [expected OK] /trusted-types/trusted-types-report-only.html
CRASH [expected OK] /websockets/unload-a-document/003.html

Stable unexpected results that are known to be intermittent (20)

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 18 more unexpected results...

OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = string
```
assert_false: expected false got true
```
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = arraybuffer
```
assert_false: expected false got true
```
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = blob
```
assert_false: expected false got true
```
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '400 425' over '350 399'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '351 398' over '501 550'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 20deg' over 'oblique 10deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -10deg' should prefer 'oblique 0deg 10deg' over 'oblique 40deg 50deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
FAIL [expected PASS] /css/css-text-decor/text-underline-position-from-font-variable.html (#45615)
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- PASS [expected FAIL] subtest: moveBefore(): cross-origin iframe is preserved: remove self
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-origin destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected PASS] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
TIMEOUT /html/syntax/parsing/html5lib_write.html?file=processing-instructions (#46205)
- TIMEOUT [expected FAIL] subtest: <body><?hey\rthere=1?>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?hey\fthere=1?>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?something ? >
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?something x >
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?something ?\t ??>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?all-KINDS-of-CaSeS data>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?user_name>
```
Test timed out
```
OK [expected TIMEOUT] /html/syntax/parsing/html5lib_write_single.html?file=processing-instructions (#46206)
TIMEOUT [expected OK] /infrastructure/testdriver/click_nested.html (#43887)
- NOTRUN [expected FAIL] subtest: TestDriver click method with multiple windows and nested iframe
OK /resource-timing/buffer-full-then-increased.html (#44408)
- PASS [expected FAIL] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event

OK /touch-events/hover-state-caused-by-compatibility-mouse-events.tentative.html (#46277)

FAIL [expected PASS] subtest: The compatibility mouse events should set :hover: The compatibility mouse events should be fired

assert_equals: expected "[{ type: \"mouseover\", target: div.target },{ type: \"mousemove\", target: div.target },{ type: \"mousedown\", target: div.target },{ type: \"mouseup\", target: div.target },{ type: \"click\", target: div.target }]" but got "[]"

FAIL [expected PASS] subtest:

The compatibility mouse events should set :hover, but shouldn't be preserved after the target is replaced: The compatibility mouse events should be fired

assert_equals: expected "[{ type: \"mouseover\", target: div.target },{ type: \"mousemove\", target: div.target },{ type: \"mousedown\", target: div.target },{ type: \"mouseup\", target: div.target },{ type: \"click\", target: div.target }]" but got "[]"

OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- FAIL [expected PASS] subtest: Click event should be fired when touchend opens synchronous XHR
```
assert_equals: expected "touchend@div, mousedown@div, mouseup@div, click@div" but got "touchend@div"
```
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?16-20 (#44835)
- TIMEOUT [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in enforcing mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a frame via area with javascript:-urls in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in report-only mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected FAIL] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

github-actions · 2026-07-14T15:21:30Z

✨ Try run (#29341897835) succeeded.

The previous logic was working well with an LTR direction, but was broken in RTL. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>

Loirooriol requested a review from mrobinson as a code owner July 14, 2026 14:40

Loirooriol added A-layout/floats A-layout/inline T-linux-wpt Do a try run of the WPT labels Jul 14, 2026

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 14, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Jul 14, 2026

Loirooriol force-pushed the float-inline branch from 3d5d11d to 20a3d25 Compare July 14, 2026 16:40

mrobinson changed the title ~~layout: Fix position adjustment of floats in inline layout~~ layout: Account for nested inline boxes when adjusting floats in inline layout Jul 14, 2026

mrobinson approved these changes Jul 14, 2026

View reviewed changes

Comment thread components/layout/flow/inline/line.rs

Comment thread components/layout/flow/inline/line.rs Outdated

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 14, 2026

mrobinson changed the title ~~layout: Account for nested inline boxes when adjusting floats in inline layout~~ layout: Account for nested inline boxes when adjusting floats in RTL inline layout Jul 14, 2026

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 14, 2026

Loirooriol enabled auto-merge July 14, 2026 17:59

layout: Fix position adjustment of floats in inline layout

01dc918

The previous logic was working well with an LTR direction, but was broken in RTL. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>

Loirooriol force-pushed the float-inline branch from 2b03110 to 01dc918 Compare July 14, 2026 18:29

Loirooriol added this pull request to the merge queue Jul 14, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 14, 2026

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 14, 2026

Loirooriol added this pull request to the merge queue Jul 14, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 14, 2026

Merged via the queue into servo:main with commit 313b6d5 Jul 14, 2026
34 checks passed

Loirooriol deleted the float-inline branch July 14, 2026 23:57

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 14, 2026

Navigation Menu

Uh oh!

Uh oh!

layout: Account for nested inline boxes when adjusting floats in RTL inline layout - #46500

layout: Account for nested inline boxes when adjusting floats in RTL inline layout#46500
Loirooriol merged 1 commit into
servo:mainfrom
Loirooriol:float-inline

Loirooriol commented Jul 14, 2026 •

edited by mrobinson

Loading

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Loirooriol commented Jul 14, 2026 • edited by mrobinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Loirooriol commented Jul 14, 2026 •

edited by mrobinson

Loading