script: Update shadow tree after an <option> element is picked to update visuals of <select> element by rhit-kapilaar · Pull Request #46386 · servo/servo

rhit-kapilaar · 2026-07-08T16:08:04Z

Previously, if a user uses <script> to make a <option> element selected, the change wouldn't get reflected for the <select> element. This is because there was nothing that updated the shadow tree. I thus updated htmloptionelement.rs making the pick_if_selected_and_reset function use &mut JSContext and passing the cx to a update_shadow_tree() call after picking the selected option.

Testing: This change adds html/semantics/forms/the-select-element/select-setting-selected-option-from-js-updates-visible-state.html.
Fixes: #46356

servo-wpt-sync · 2026-07-08T16:13:43Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#61158) with upstreamable changes.

rhit-kapilaar · 2026-07-08T17:08:13Z

@simonwuelker does this look good?

github-actions · 2026-07-08T21:08:52Z

🔨 Triggering try run (#28975862353) for Linux (WPT)

github-actions · 2026-07-08T21:45:30Z

Test results for linux-wpt from try job (#28975862353):

Flaky unexpected result (39)

CRASH [expected OK] /_mozilla/mozilla/input-value.html
TIMEOUT [expected OK] /_webgl/conformance/reading/read-pixels-test.html
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-06.html
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-14.html
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-16.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance2/state/gl-object-get-calls.html
TIMEOUT [expected OK] /_webgl/conformance2/sync/sync-webgl-specific.html
TIMEOUT [expected OK] /cookies/attributes/domain.sub.html
- TIMEOUT [expected FAIL] subtest: Empty domain treated as host cookie 1
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Empty domain treated as host cookie 2
- NOTRUN [expected PASS] subtest: Empty domain treated as host cookie 3
- NOTRUN [expected PASS] subtest: No host cookies returned for host cookies after non-host redirect 1
- NOTRUN [expected PASS] subtest: No host cookies returned for host cookies after non-host redirect 2
- NOTRUN [expected PASS] subtest: No host cookies returned for host cookies after non-host redirect 3
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html (#45255)
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique 40deg 50deg' over 'italic'
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#45763)
CRASH [expected FAIL] /css/selectors/invalidation/nth-last-child-of-class-prefix.html
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/gzip/big-gzip-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large gzip data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large gzip data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-window-zstd-body.tentative.https.any.worker.html
- TIMEOUT [expected FAIL] subtest: Consuming the body of a resource with too large of a zstd window size should reject
```
Test timed out
```
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.html
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large zstd data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large zstd data should be decompressed successfully with byte stream
ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-initial-navigation.html (#40387)
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/browsers/origin/cross-origin-objects/cross-origin-objects.html
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- PASS [expected TIMEOUT] subtest: HTMLMediaElement.srcObject blob

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-window-open.html (#32596)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: location.replace

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

CRASH [expected ERROR] /html/semantics/forms/the-select-element/customizable-select/select-appearance-button-after-span.html
CRASH [expected FAIL] /html/semantics/interestfor/interestfor-plain-inline-element.tentative.html
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html (#42419)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- FAIL [expected PASS] subtest: Cross-Origin video should get upgraded even if CORS is set
```
assert_equals: Length. Other host expected 1 but got Infinity
```
OK /paint-timing/fcp-only/fcp-svg.html (#45878)
- PASS [expected FAIL] subtest: First contentful paint fires when SVG becomes contentful.

OK /pointerevents/compat/pointerevent_touch_target_after_pointerdown_target_removed.tentative.html (#42813)

FAIL [expected PASS] subtest:

After a pointerdown listener removes its target, touch events should be fired on the touchstart target even though an orphan and pointer events should be fired on the parent

assert_equals: expected "[ { type: pointerdown, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: touchstart, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointermove, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: pointerup, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: touchend, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; } ]" but got "[ { type: pointerdown, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: touchstart, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointermove, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: pointerup, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: touchend, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointermove, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: pointerdown, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: pointerup, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; } ]"

FAIL [expected PASS] subtest: After a pointerdown listener removes its target, touchmove event should be fired on the pointerdown target

assert_equals: expected "[ { type: pointerdown, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: touchstart, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointermove, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: touchmove, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointerup, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: touchend, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; } ]" but got "[ { type: pointerdown, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: touchstart, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointermove, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: touchmove, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointerup, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: touchend, target: Element node &lt;div id=\"pointerDownTarget\"&gt;&lt;/div&gt; }, { type: pointermove, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: pointerdown, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; }, { type: pointerup, target: Element node &lt;div id=\"pointerDownTargetParent\"&gt;&lt;/div&gt; } ]"

PASS [expected FAIL] subtest: After a touchstart listener removes its target, touch events should be fired on the touchstart target even though an orphan and pointer events should be fired on the parent
PASS [expected FAIL] subtest: After a touchstart listener removes its target, touchmove event should be fired on the pointerdown target

OK /pointerevents/pointerevent_pointercapture_in_frame.html?touch (#45445)

FAIL [expected PASS] subtest: Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture.
```
assert_true: Timed out waiting for lostpointercapture expected true got false
```

FAIL [expected PASS] subtest:

Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture to outer frame should not capture.

assert_array_equals: Received events: innerFrame received pointerdown,innerFrame received pointermove,innerFrame received pointerup,innerFrame received lostpointercapture lengths differ, expected array ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup"] length 3, got ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup", "innerFrame received lostpointercapture"] length 4

OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)

FAIL [expected PASS] subtest: Validate render blocking status of link resources in PerformanceResourceTiming

assert_equals: render blocking status for http://web-platform.test:8000/resource-timing/resources/empty_style.css?stylesheet-head-dynamic-docWrite should be blocking expected (string) "blocking" but got (undefined) undefined

TIMEOUT /resource-timing/response-status-code.html
- TIMEOUT [expected FAIL] subtest: This test validates the response status of resources. 98
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: This test validates the response status of resources. 99
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (iframe)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (script)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
OK /touch-events/mouseevents-after-touchend.tentative.html
- PASS [expected FAIL] subtest: Tapping too far points should not cause a dblclick
CRASH [expected OK] /trusted-types/TrustedTypePolicyFactory-createPolicy-unenforced.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?11-15 (#44834)
- PASS [expected TIMEOUT] subtest: Navigate a window via area with javascript:-urls in report-only mode.
OK /upgrade-insecure-requests/gen/sharedworker-module-data.meta/unset/fetch.https.html
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to cross-http-downgrade origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to cross-http-downgrade origin and no-redirect redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to cross-https origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to same-http-downgrade origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to same-http-downgrade origin and no-redirect redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to same-https origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected FAIL] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

Stable unexpected results that are known to be intermittent (19)

OK /IndexedDB/idbtransaction-oncomplete.any.html (#42845)

FAIL [expected PASS] subtest: IDBTransaction - complete event

assert_array_equals: lengths differ, expected array ["upgradeneeded", "complete", "success", "opencursor"] length 4, got ["upgradeneeded", "complete", "success"] length 3

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 22 more unexpected results...

TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- PASS [expected FAIL] subtest: moveBefore(): cross-origin iframe is preserved: remove self
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-origin destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#44099)

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by submitButton.click()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20const%20button%20%3D%20document.createElement(%22button%22)%3B%0A%20%20%20%20button.type%20%3D%20%22submit%22%3B%0A%20%20%20%20form.append(button)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20button.click()%3B%0A%20%20"

CRASH [expected ERROR] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html (#44058)
- PASS [expected FAIL] subtest: Parse errors in different files should be reported depending on different roots
TIMEOUT /html/syntax/parsing/html5lib_write.html?file=processing-instructions (#46205)
- TIMEOUT [expected FAIL] subtest: <body><?x>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?100%>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?start data
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?start ? ?
```
Test timed out
```
TIMEOUT /html/syntax/parsing/html5lib_write_single.html?file=processing-instructions (#46206)
- TIMEOUT [expected FAIL] subtest: <body><?user_name>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?user_name data>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?S_S-S_S>
```
Test timed out
```
OK /resource-timing/buffer-full-then-increased.html (#44408)
- PASS [expected FAIL] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event

OK /touch-events/hover-state-caused-by-compatibility-mouse-events.tentative.html (#46277)

FAIL [expected PASS] subtest: The compatibility mouse events should set :hover: The compatibility mouse events should be fired

assert_equals: expected "[{ type: \"mouseover\", target: div.target },{ type: \"mousemove\", target: div.target },{ type: \"mousedown\", target: div.target },{ type: \"mouseup\", target: div.target },{ type: \"click\", target: div.target }]" but got "[]"

FAIL [expected PASS] subtest:

The compatibility mouse events should set :hover, but shouldn't be preserved after the target is replaced: The compatibility mouse events should be fired

assert_equals: expected "[{ type: \"mouseover\", target: div.target },{ type: \"mousemove\", target: div.target },{ type: \"mousedown\", target: div.target },{ type: \"mouseup\", target: div.target },{ type: \"click\", target: div.target }]" but got "[]"

TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?16-20 (#44835)
- FAIL [expected PASS] subtest: Navigate a frame via area with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- TIMEOUT [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
- NOTRUN [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.

github-actions · 2026-07-08T21:45:37Z

✨ Try run (#28975862353) succeeded.

servo-wpt-sync · 2026-07-09T08:50:52Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#61158) title and body.

mrobinson

The new test should probably go into tests/wpt/tests/html/rendering/replaced-elements/the-select-element/ as this is about rendering and not semantics.

mrobinson · 2026-07-09T08:50:18Z

+<select id="select">
+    <option id="20" value="20">20</option>
+    <option id="10" value="10">10</option>
+</select>


This file is missing an ending newline, which Git doesn't really like. Also please add a header to this file -- you can find other examples of how reference files should look by looking through these directories.

mrobinson · 2026-07-09T08:53:02Z

+    <option id="20" value="20">20</option>
+    <option id="10" value="10">10</option>
+</select>


Would it be possible to use selected="20" here instead of changing the option order?

I kind of based format of a PR for a similar issue -> https://github.com/servo/servo/pull/46230/changes

Also, doing selected=20 or value=20 don't work. However, putting the selected attribute on the 20 option still works so I could potentially do that instead of changing option order.

servo-wpt-sync · 2026-07-09T08:56:27Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#61158) title and body.

rhit-kapilaar · 2026-07-09T12:54:54Z

probably go into tests/wpt/tests/html/rendering/replaced-elements/the-select-element/

So I had actually based my tests of this former PR which fixes a very similar issue and has almost the same ref file -> https://github.com/web-platform-tests/wpt/pull/61062/changes so I was wondering what should be done because in either case I think it makes sense to have the tests for both PRs in the same folder (they test almost the same thing).

simonwuelker · 2026-07-09T15:53:28Z

probably go into tests/wpt/tests/html/rendering/replaced-elements/the-select-element/

So I had actually based my tests of this former PR which fixes a very similar issue and has almost the same ref file -> https://github.com/web-platform-tests/wpt/pull/61062/changes so I was wondering what should be done because in either case I think it makes sense to have the tests for both PRs in the same folder (they test almost the same thing).

Feel free to move my test over as well if you want, html/rendering/ ... is a better place for them.

…ript Signed-off-by: Avi Raj Kapila <[email protected]>

servo-wpt-sync · 2026-07-09T17:28:45Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#61158).

…sible-state to correct location Signed-off-by: Avi Raj Kapila <[email protected]>

servo-wpt-sync · 2026-07-09T17:35:50Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#61158).

servo-wpt-sync · 2026-07-09T17:41:24Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#61158).

rhit-kapilaar requested a review from gterzian as a code owner July 8, 2026 16:08

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 8, 2026

rhit-kapilaar mentioned this pull request Jul 8, 2026

<select> does not respect 'select' attribute added via <script> tag #46356

Closed

servo-wpt-sync mentioned this pull request Jul 8, 2026

script: Update shadow tree after an <option> element is picked to update visuals of <select> element web-platform-tests/wpt#61158

Merged

simonwuelker added the T-linux-wpt Do a try run of the WPT label Jul 8, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Jul 8, 2026

mrobinson requested changes Jul 9, 2026

View reviewed changes

servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 9, 2026

Added support for making an option selected for <select> using javasc…

a073781

…ript Signed-off-by: Avi Raj Kapila <[email protected]>

rhit-kapilaar force-pushed the rhit-kapilaar/select-setting-selected-with-js branch from 36687d2 to a073781 Compare July 9, 2026 17:21

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Jul 9, 2026

Moved over wpt test files for select-setting-value-from-js-updates-vi…

95e8a24

…sible-state to correct location Signed-off-by: Avi Raj Kapila <[email protected]>

rhit-kapilaar force-pushed the rhit-kapilaar/select-setting-selected-with-js branch from 2bb2c5d to 95e8a24 Compare July 9, 2026 17:31

mrobinson approved these changes Jul 10, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 10, 2026

mrobinson added this pull request to the merge queue Jul 10, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 10, 2026

Merged via the queue into servo:main with commit e1d5f1a Jul 10, 2026
31 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 10, 2026

Uh oh!

Uh oh!

Conversation

rhit-kapilaar commented Jul 8, 2026 • edited by mrobinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Jul 8, 2026

Uh oh!

rhit-kapilaar commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

servo-wpt-sync commented Jul 9, 2026

Uh oh!

mrobinson left a comment

Choose a reason for hiding this comment

Uh oh!

mrobinson Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

mrobinson Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

rhit-kapilaar Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

servo-wpt-sync commented Jul 9, 2026

Uh oh!

rhit-kapilaar commented Jul 9, 2026

Uh oh!

simonwuelker commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Jul 9, 2026

Uh oh!

servo-wpt-sync commented Jul 9, 2026

Uh oh!

servo-wpt-sync commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rhit-kapilaar commented Jul 8, 2026 •

edited by mrobinson

Loading

simonwuelker commented Jul 9, 2026 •

edited

Loading