script: Finish JSContextify, remove CanGc and CanGc reflect methods - #46333
Merged
Merged
Conversation
Contributor
Author
Narfinger
force-pushed
the
super-jscontextify-world
branch
from
July 7, 2026 07:26
86deee1 to
d7bda01
Compare
TimvdLippe
reviewed
Jul 7, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Super exciting to see this one close in!
Narfinger
force-pushed
the
super-jscontextify-world
branch
from
July 7, 2026 07:45
d7bda01 to
690d618
Compare
TimvdLippe
reviewed
Jul 7, 2026
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Narfinger
force-pushed
the
super-jscontextify-world
branch
from
July 7, 2026 10:03
690d618 to
f01822e
Compare
Contributor
Author
|
Please note the change in the description to highlight the ShadowRoot::register_element_id. |
Narfinger
marked this pull request as ready for review
July 7, 2026 10:04
TimvdLippe
approved these changes
Jul 7, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Super exciting to see this land
TimvdLippe
enabled auto-merge
July 7, 2026 10:12
|
Someone thinks this change could be added to the monthly blog post! To help with this, we need someone to answer the following questions: 😄
If this change is part of a broader feature/project please make sure the PR description contains a Please add Thanks for helping us prepare the monthly blog post! ❤️ |
Contributor
|
@servo-highfive monthly update answer
Feel free to make this a tad bigger section in the blog post, but this is the gist of it |
Narfinger
added a commit
to Narfinger/servo
that referenced
this pull request
Jul 7, 2026
…ervo#46333) (linux-wpt-debugmozjs) {"fail_fast": false, "matrix": [{"name": "Linux (Debug Mozjs, WPT)", "workflow": "linux", "wpt": true, "profile": "checked-release", "unit_tests": false, "devtools_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "capi": false, "build_args": "--debug-mozjs", "wpt_args": "", "number_of_wpt_chunks": 20}]}
mu-mostafa98
pushed a commit
to mu-mostafa98/servo
that referenced
this pull request
Jul 16, 2026
…ervo#46552) Remove duplicate `LargestContentfulPaint` in `Bindings.conf` First Addition in servo#46318 Second Addition in servo#46333 Testing: Existing WPT Signed-off-by: Shubham Gupta <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final part of the work to move to JSContext instead of CanGc. With this we deprecate all remaining usages of CanGc and remove CanGc and the reflect method using CanGc from the codebase.
Notice that ShadowRoot::register_element_id had previously a CanGc argument which seems unnecessary and was removed.
Part of #40600
Testing: Compilation is the test.