Script: Enable SVG presentation attributes with updated stylo dependency - #45405
Merged
Loirooriol merged 8 commits intoJul 11, 2026
Merged
Conversation
|
🔨 Triggering try run (#26994757902) for Linux (WPT) |
|
Test results for linux-wpt from try job (#26994757902): Flaky unexpected result (48)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (81)
|
|
|
Contributor
|
You can run |
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
3 times, most recently
from
June 6, 2026 03:35
d88a679 to
86d93c3
Compare
Contributor
|
Test results look good. Are your PRs ready for review? If so, please unmark them as draft so folks can take a look. Thanks a lot for tackling these! |
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
2 times, most recently
from
June 8, 2026 02:42
1556c57 to
e7526f0
Compare
shubhamg13
reviewed
Jun 8, 2026
shubhamg13
reviewed
Jun 8, 2026
shubhamg13
reviewed
Jun 8, 2026
Comment on lines
+1383
to
+1384
| if let Ok(decl) = parser.parse_entirely(|p| { | ||
| style::properties::longhands::$css_property::parse_declared(&parser_context, p) |
Member
There was a problem hiding this comment.
Can we make this little Rusty aka Rust Style
Suggested change
| if let Ok(decl) = parser.parse_entirely(|p| { | |
| style::properties::longhands::$css_property::parse_declared(&parser_context, p) | |
| parser.parse_entirely(|p| { | |
| style::properties::longhands::$css_property::parse_declared(&parser_context, p) | |
| }).map(|decl| push(decl)).ok(); |
Same for below.
shubhamg13
reviewed
Jun 8, 2026
shubhamg13
left a comment
Member
There was a problem hiding this comment.
Cheers. A lot of WPT Passing
| @@ -0,0 +1,3 @@ | |||
| [spaces-at-end-of-path-data.html] | |||
| [Allow trailing empty entry in value list] | |||
| expected: FAIL | |||
Contributor
There was a problem hiding this comment.
We can allow some new FAIL cases when the amount of PASS is out number.
It's good to explain when the PR is finalized.
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
2 times, most recently
from
June 9, 2026 04:24
3e0ff78 to
3c945f2
Compare
shubhamg13
approved these changes
Jun 9, 2026
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
2 times, most recently
from
June 9, 2026 07:59
497ec27 to
9d701bb
Compare
xiaochengh
reviewed
Jun 9, 2026
| attr_to_css_decl!("stroke-miterlimit" => stroke_miterlimit); | ||
| attr_to_css_decl!("stroke-opacity" => stroke_opacity); | ||
|
|
||
| if *name == *local_name!("circle") { |
Contributor
There was a problem hiding this comment.
It seems wrong to directly look at the local name. Eventually we should inspect the runtime type. However, that's currently not possible without introducing SVGXXXElement types and adding parser support.
Let's remove them from this PR and add them in the next PR where we add the new DOM types for the basic shapes.
mrobinson
previously requested changes
Jun 9, 2026
Comment on lines
1377
to
1387
| macro_rules! attr_to_css_decl { | ||
| ($attr_name:tt => $css_property:ident) => { | ||
| if let Some(val) = self.get_attr_val_for_layout(&ns!(), &local_name!($attr_name)) { | ||
| let mut input = ParserInput::new(val); | ||
| let mut parser = Parser::new(&mut input); | ||
| parser.parse_entirely(|p| { | ||
| style::properties::longhands::$css_property::parse_declared(&parser_context, p) | ||
| }).map(|decl| push(decl)).ok(); | ||
| } | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
I think we should avoid the usage of a macro here and in addition do not use abbreviations for variable names: https://book.servo.org/contributing/style-guide.html
Contributor
Author
There was a problem hiding this comment.
Done
- Replaced the macro with the
SVGElement::parse_svg_attributehelper function - Expanded abbreviated variable names (
val → value, p → parse_input, decl → declaration)
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
3 times, most recently
from
June 9, 2026 14:52
50a5ed0 to
5f34a3e
Compare
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
from
July 10, 2026 12:02
04cd4be to
7c77faf
Compare
simonwuelker
pushed a commit
to simonwuelker/stylo
that referenced
this pull request
Jul 10, 2026
Removes `engine = "gecko"` from 11 SVG-specific CSS properties to be enabled for servo: - **Fill (3):** `fill`, `fill-opacity`, `fill-rule` - **Stroke (8):** `stroke`, `stroke-width`, `stroke-linecap`, `stroke-linejoin`, `stroke-dasharray`, `stroke-dashoffset`, `stroke-miterlimit`, `stroke-opacity` Also updates the `ComputedValues` size test (224 → 232) for the new fields. Servo [PR](servo/servo#45405) --------- Signed-off-by: Mohamed Mostafa [email protected] Co-authored-by: Mohamed Mostafa <[email protected]>
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
from
July 10, 2026 13:48
7c77faf to
022b9a4
Compare
jdm
enabled auto-merge
July 10, 2026 13:56
Member
|
Bleach, pressed the wrong button and triggered the branch update. |
auto-merge was automatically disabled
July 10, 2026 14:01
Head branch was pushed to by a user without write access
mu-mostafa98
force-pushed
the
svg-presentationall-attributes
branch
from
July 10, 2026 14:01
4e3f83d to
1ce76cb
Compare
Contributor
Author
The PR now uses the latest stylo |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 10, 2026
Signed-off-by: Mohamed Mostafa <[email protected]>
Co-authored-by: Josh Matthews <[email protected]> Signed-off-by: Mohamed Mostafa <[email protected]>
Co-authored-by: Josh Matthews <[email protected]> Signed-off-by: Mohamed Mostafa <[email protected]>
Signed-off-by: Mohamed Mostafa <[email protected]>
Signed-off-by: Mohamed Mostafa <[email protected]>
Signed-off-by: Mohamed Mostafa <[email protected]>
Signed-off-by: Mohamed Mostafa <[email protected]>
Signed-off-by: Mohamed Mostafa <[email protected]>
Loirooriol
force-pushed
the
svg-presentationall-attributes
branch
from
July 11, 2026 00:17
1ce76cb to
e416a5e
Compare
Contributor
|
Rebased after #45492 |
Loirooriol
enabled auto-merge
July 11, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for Servo.