servoshell: Align console behavior for shell and double‑click launches - #43010
Conversation
Signed-off-by: Euclid Ye <[email protected]>
|
Won't this still spawn the console, so you'll get this "flashing console window that immediately disappears" effect when starting via GUI? |
It is much better as the issue #40996 fixed is much more severe. This also allows: seeing the follow-up stdout/stderr, if started executable from console. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Video can explain better. previous.mp4now.mp4no_blink_even_in_debug.mp4 |
|
My main concern is that I believe the original decision (when production builds just had no output at all) was AFAIK made to avoid exactly that blinking, since it could be "suspicous" to users. So I think this PR might need wider review, to ensure there is consensus. |
|
🔨 Triggering try run (#22660422044) for Windows |
|
✨ Try run (#22660422044) succeeded. |
I honestly find current console output behaviour much more suspicious as shown in videos. Maybe this can be discussed in Zulip. |
|
IIRC that is related to shell somehow. I think using bash (from git-windows) works as expected (like on linux). With that being said, I support this change as I find this inconsistent unexpected. |
|
Any chance we can advance this? |
|
Someone thinks this change could be added to the monthly blog post! To help with this, we need someone to answer the following questions: 😄
If this change is part of a broader feature/project please make sure the PR description contains a Please add Thanks for helping us prepare the monthly blog post! ❤️ |
|
I will get back to this bot message after figuring out what's the new label about |
|
We have a new monthly update label, which make it easier for the people writing the monthly blog-post to include noteworthy additions, if the contributor shortly explains what the PR is about. Since you already posted videos in the comment above, and it affects windows users, I thought this might be fitting (although in the end the blog post author decides what to include) |
|
@servo-highfive monthly update answer
previous.mp4now.mp4
|
In addition to issues fixed, this also allows: seeing the follow-up stdout/stderr, if started executable from console.
Testing: Manually tested, started both from GUI double-click and console. We still maintain the no-popup behaviour when started from GUI.
Fixes: #40996