Make transition_to asynchronous by default - #4849
Merged
Merged
Conversation
execute_transition for synchronous transitions.
toots
enabled auto-merge
January 20, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
transition_toasynchronous by default and adds an explicitexecute_transitionfor synchronous transitions.This is meant to address issues such as #4840.
The problem with these issues is that we change the execution status of the output while it is concurrently in a streaming cycle, cause inconsistent states where the output is expecting to have an encoder.
Instead, except when explicitly needed, we should wait for the next streaming cycle and execute the state change before entering it.
States changes are queued so that e.g. a reset, i.e. a
stopfollowed by astartwill still happen at once during the next streaming cycle.Fixes: #4840
TODO