conn: yield received plaintext from a lending iterator - #3149
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Memory usageKey:
Significant differencesClick to expand
Additional informationCheckout details:
|
ctz
reviewed
Jul 14, 2026
ctz
left a comment
Member
There was a problem hiding this comment.
I suggest we do the first two commits separately, as aren't really controversial
djc
force-pushed
the
message-iter-next
branch
2 times, most recently
from
July 15, 2026 10:48
9034a9c to
2771cd7
Compare
djc
commented
Jul 15, 2026
djc
force-pushed
the
message-iter-next
branch
6 times, most recently
from
July 16, 2026 08:20
9773fad to
939c298
Compare
djc
marked this pull request as ready for review
July 16, 2026 08:21
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
- Coverage 95.35% 95.31% -0.04%
==========================================
Files 99 99
Lines 23183 23143 -40
Branches 671 672 +1
==========================================
- Hits 22106 22059 -47
- Misses 925 928 +3
- Partials 152 156 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djc
commented
Jul 16, 2026
ctz
reviewed
Jul 16, 2026
djc
force-pushed
the
message-iter-next
branch
2 times, most recently
from
July 31, 2026 09:52
f7a9e8f to
615aa41
Compare
ctz
approved these changes
Aug 4, 2026
| #[test] | ||
| fn streamowned_can_be_created_for_client_and_tcpstream() { | ||
| type _Test = StreamOwned<ClientConnection, TcpStream>; | ||
| type _Test = StreamOwned<ClientConnection, ServerSide, TcpStream>; |
Member
There was a problem hiding this comment.
this is wrong. (can the bound be put on the struct?)
Member
Author
There was a problem hiding this comment.
What do you mean by putting the bound on the struct?
Member
There was a problem hiding this comment.
Bare in mind first my confidence with rust type golf is low. Can trait Connection require each impl exposes its Side: SideData value as an associated item? Then it doesn't need to be restated here, and any references to it can be C::Side instead.
Member
Author
There was a problem hiding this comment.
Bare in mind first my confidence with rust type golf is low. Can
trait Connectionrequire each impl exposes itsSide: SideDatavalue as an associated item? Then it doesn't need to be restated here, and any references to it can beC::Sideinstead.
It could but I think it would preclude the use of dyn Connection which we're using in some places, which makes it a larger change at the least (and probably triggers some of the monomorphization things you tend to dislike).
| let iter = server.process_new_packets(&mut server_input); | ||
| let mut received = Vec::with_capacity(16); | ||
| let state = iter.handle_all(&mut received).unwrap(); | ||
| assert!(state.peer_has_closed()); |
Member
There was a problem hiding this comment.
assert_eq!(received, b"from-client!"); here or similar -- it is important that peer_has_closed() does not overtake appdata.
in addition tests that do not consume the whole of iter should see no peer_has_closed() here for the same reason.
Member
Author
There was a problem hiding this comment.
assert_eq!(received, b"from-client!");here or similar -- it is important thatpeer_has_closed()does not overtake appdata.
Done.
in addition tests that do not consume the whole of
itershould see nopeer_has_closed()here for the same reason.
Did you see concrete instances of this?
djc
enabled auto-merge
August 5, 2026 08:59
Member
Author
|
With your approval, going to merge this. Happy to take further feedback of course, and noting to
next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ctz early feedback?