Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesClick to expand
Additional informationCheckout details:
|
djc
force-pushed
the
depub
branch
7 times, most recently
from
June 17, 2026 14:54
33c9c15 to
c1b5e44
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
==========================================
+ Coverage 93.16% 93.27% +0.11%
==========================================
Files 98 98
Lines 22369 22329 -40
Branches 641 641
==========================================
- Hits 20839 20827 -12
+ Misses 1382 1354 -28
Partials 148 148 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djc
marked this pull request as draft
June 17, 2026 15:21
djc
force-pushed
the
depub
branch
2 times, most recently
from
June 17, 2026 15:41
2931cd2 to
d696a97
Compare
ctz
reviewed
Jun 18, 2026
ctz
left a comment
Member
There was a problem hiding this comment.
depub probably ought to operate on code/tokens rather than with sed-like blind textual replacement
| { | ||
| debug!( | ||
| "selected ECH config ID {:?} suite {:?} public_name {:?}", | ||
| "selected ECH config ID {:?} suite {:?} lic_name {:?}", |
| /// Convert a public key and algorithm identifier into [`SubjectPublicKeyInfoDer`]. | ||
| /// | ||
| /// In the returned encoding, `alg_id` is used as the `algorithm` field, and `public_key` is | ||
| /// In the returned encoding, `alg_id` is used as the `algorithm` field, and `lic_key` is |
| /// | ||
| /// Custom implementations should complete the key exchange by calling | ||
| /// `kx.complete(peer_pub_key)` and then using this as the input keying material to | ||
| /// `kx.complete(peer__key)` and then using this as the input keying material to |
| /// | ||
| /// ```no_compile | ||
| #[doc = concat!("pub const MyValue: ", stringify!($struct_name), " = ", stringify!($struct_name), "(123);")] | ||
| #[doc = concat!(" const MyValue: ", stringify!($struct_name), " = ", stringify!($struct_name), "(123);")] |
| /// Remove the extension identified by `typ` from `self`. | ||
| #[allow(dead_code)] | ||
| pub(crate) fn clear(&mut self, typ: ExtensionType) { | ||
| fn clear(&mut self, typ: ExtensionType) { |
|
|
||
| /// Return true if there are no certificates. | ||
| pub fn is_empty(&self) -> bool { | ||
| pub(super) fn is_empty(&self) -> bool { |
|
|
||
| /// APIs abstracting over locking primitives. | ||
| pub mod lock; | ||
| mod lock; |
| @@ -1,18 +1,17 @@ | |||
| pub use std_lock::*; | |||
| pub(super) use std_lock::*; | |||
| /// | ||
| /// This means all the constituent parts that do cryptography return `true` for `fips()`. | ||
| pub fn fips(&self) -> FipsStatus { | ||
| pub(super) fn fips(&self) -> FipsStatus { |
| TLS13(&'static Tls13Version), | ||
| } | ||
|
|
||
| impl SupportedProtocolVersion { |
Member
Author
Yeah -- I already reverted a bunch of these cases. In the meantime, this will hopefully help: |
tgeoghegan
added a commit
to tgeoghegan/rustls
that referenced
this pull request
Aug 31, 2026
The DTLS 1.3 AAD consists of the encoded unified header, which is very different from DTLS 1.2 or TLS 1.3 [1]. This requires plumbing that unified header all the way into the record layer DecryptionState, which would take some dramatic refactoring. For now, we hack around the issue by making it behave like TLS 1.3, forcing content type to ApplicationData. All this will require some beefy refactoring of the crypto providers along the lines of what I proposed in that issue, maybe rustls#3090. We should also get rid of the ContentType::Dtls13Ciphertext variant. Instead we should probably be using whatever the content type in a deprotected record is. [1]: https://datatracker.ietf.org/doc/html/draft-ietf-tls-rfc9147bis-02#section-4-16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried out depub on rustls.
Not sure if worth it? But seems interesting.